Override default scope for Workshop#2515
Merged
olleolleolle merged 1 commit intomasterfrom Mar 10, 2026
Merged
Conversation
The default_scope for Workshop sorts events in descending order. For future events, we want them sorted in ascending order (ie soonest first). Because I don't know why this scope was added, and where else it's used, I'm not going to change it. Instead, I've updated the two 'upcoming' scopes to override the default ordering. I tested this by generating 15 Workshops for various times over the next two weeks. Without this fix, the workshops were the 5 furthest from this point in time. With this fix, they were the 5 soonest. Signed-off-by: jonathan.kerr <3410350+jonodrew@users.noreply.github.com>
Contributor
Author
|
Tests are all passing locally for me, so will rerun the failing set |
octoberclub
approved these changes
Mar 9, 2026
octoberclub
left a comment
octoberclub
left a comment
There was a problem hiding this comment.
Default scopes can trip you up! Seems like a simple fix so approved it.
olleolleolle
approved these changes
Mar 10, 2026
Collaborator
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
Ah, default_scope (ow, the Old Wound!).
mroderick
added a commit
to mroderick/codebar-planner
that referenced
this pull request
Mar 10, 2026
Add tests to verify that today_and_upcoming and upcoming scopes return workshops in ascending order (soonest first), overriding the Workshop default_scope which orders in descending order. This ensures the fix in PR codebar#2515 is properly covered by tests.
olleolleolle
added a commit
that referenced
this pull request
Mar 10, 2026
test: Add tests for upcoming scope ordering fix (PR #2515)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default_scope for Workshop sorts events in descending order. For future events, we want them sorted in ascending order (ie soonest first). Because I don't know why this scope was added, and where else it's used, I'm not going to change it. Instead, I've updated the two 'upcoming' scopes to override the default ordering.
I tested this by generating 15 Workshops for various times over the next two weeks. Without this fix, the workshops were the 5 furthest from this point in time. With this fix, they were the 5 soonest.