Skip to content

Conversation

@codeZeilen
Copy link
Owner

@codeZeilen codeZeilen commented Apr 14, 2025

Open issues:

  • What is the file extension for test suites? Currently it is .rosetta
  • What is the name of the language? Currently, it is RosettaTestLang to avoid the conflict with the (vanished) RosettaLang (https://en.wikipedia.org/wiki/Rosetta-lang)

@codeZeilen codeZeilen requested review from Copilot and peret April 14, 2025 09:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 354 out of 369 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • .gitattributes: Language not supported
  • .smalltalk.ston: Language not supported
  • ports-s/BaselineOfPortsS/BaselineOfPortsS.class.st: Language not supported
  • ports-s/BaselineOfPortsS/package.st: Language not supported
  • ports-s/PortsS-Core/package.st: Language not supported
  • ports-s/PortsS-Interpreter/Collection.extension.st: Language not supported
  • ports-s/PortsS-Interpreter/False.extension.st: Language not supported
  • ports-s/PortsS-Interpreter/Object.extension.st: Language not supported
  • ports-s/PortsS-Interpreter/PortsSyntaxError.class.st: Language not supported
  • ports-s/PortsS-Interpreter/PortsTypeError.class.st: Language not supported
  • ports-s/PortsS-Interpreter/package.st: Language not supported
  • ports-s/PortsS-Suites/PortsFSSuite.class.st: Language not supported
  • ports-s/PortsS-Suites/PortsJSONRfcSuite.class.st: Language not supported
  • ports-s/PortsS-Suites/package.st: Language not supported
  • ports-s/PortsS-Tests/package.st: Language not supported

Copy link
Collaborator

@peret peret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@peret
Copy link
Collaborator

peret commented Apr 17, 2025

What is the name of the language? Currently, it is RosettaTestLang to avoid the conflict with the (vanished) RosettaLang (https://en.wikipedia.org/wiki/Rosetta-lang)

Is that something that needs to be resolved for this PR to be merged?

@codeZeilen
Copy link
Owner Author

What is the name of the language? Currently, it is RosettaTestLang to avoid the conflict with the (vanished) RosettaLang (https://en.wikipedia.org/wiki/Rosetta-lang)

Is that something that needs to be resolved for this PR to be merged?

Not really, in the end it is not very user-facing anyways.

@codeZeilen codeZeilen merged commit e1d8230 into main Apr 17, 2025
4 checks passed
@codeZeilen codeZeilen deleted the name-change branch April 17, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants