Conversation
phrdang
requested review from
a team and
srikar-eranky
and removed request for
a team
phrdang
dismissed
github-actions[bot]’s stale review
flake8 rule E203 has an issue where it isn't PEP8 compliant (Black is correct)
|
@neha-peddinti please ignore the flake8 saying that the list slicing is wrong. flake8 is wrong, there's a bug in rule E203 that's being fixed. Rules flake8 GitHub |
phrdang
requested review from
a team and
Miserabl
and removed request for
a team
abhatia1205
left a comment
abhatia1205
left a comment
There was a problem hiding this comment.
This is a great problem! Only a few tweaks are required. First of all, when you call Food.__init__(self, *args), the self keyword is not supposed to be passed. Also, it is better coding practice to use the super() function instead of the name of the actual class, Food. This being said, if the students aren't yet supposed to have learned about the super function, I totally get that too.
Nice work!
Co-authored-by: abhatia1205 <32373316+abhatia1205@users.noreply.github.com>
Co-authored-by: abhatia1205 <32373316+abhatia1205@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
Co-authored-by: abhatia1205 <32373316+abhatia1205@users.noreply.github.com>
6 participants
Food Class
Ch. 12
Inheritance