Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "bug",
"message": "Fix [nuxt] instance unavailable errors",
"issue_origin": "github",
"issue_number": 5063,
"domain": "core",
"bullet_points": [],
"created_at": "2026-03-27"
}
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export class AIDatabaseOnboardingStepType extends DatabaseOnboardingStepType {
getCompletedRoute(data, responses) {
const response = responses[DatabaseOnboardingType.getType()]
nextTick(async () => {
await pageFinished()
await pageFinished(this.app)
await nextTick()
await this.app.$bus.$emit('toggle-right-sidebar', true)
await this.app.$store.dispatch('assistant/selectChat', response.chat)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export class PeriodicDataSyncDeactivatedNotificationType extends NotificationTyp

getRoute(notificationData) {
return tableRouteResetViewIfNeeded(
this.app.$router,
{
databaseId: notificationData.database_id,
tableId: notificationData.table_id,
Expand All @@ -48,6 +49,7 @@ export class TwoWayDataSyncUpdateFiledNotificationType extends NotificationType

getRoute(notificationData) {
return tableRouteResetViewIfNeeded(
this.app.$router,
{
databaseId: notificationData.database_id,
tableId: notificationData.table_id,
Expand All @@ -73,6 +75,7 @@ export class TwoWaySyncDeactivatedNotificationType extends NotificationType {

getRoute(notificationData) {
return tableRouteResetViewIfNeeded(
this.app.$router,
{
databaseId: notificationData.database_id,
tableId: notificationData.table_id,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,15 @@ import modal from '@baserow/modules/core/mixins/modal'
import error from '@baserow/modules/core/mixins/error'
import LicenseService from '@baserow_premium/services/license'
import { pageFinished } from '@baserow/modules/core/utils/routing.js'
import { nextTick } from '#imports'
import { nextTick, useNuxtApp } from '#imports'

export default {
name: 'DisconnectLicenseModal',
mixins: [modal, error],
setup() {
const nuxtApp = useNuxtApp()
return { nuxtApp }
},
props: {
license: {
type: Object,
Expand All @@ -57,8 +61,8 @@ export default {

try {
await LicenseService(this.$client).disconnect(this.license.id)
await this.$nuxt.$router.push({ name: 'admin-licenses' })
await pageFinished()
await this.$router.push({ name: 'admin-licenses' })
await pageFinished(this.nuxtApp)
await nextTick()
} catch (error) {
this.handleError(error)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,14 @@ import RegisterLicenseForm from '@baserow_premium/components/license/RegisterLic
import { ResponseErrorMessage } from '@baserow/modules/core/plugins/clientHandler'
import { getPricingURL } from '@baserow_premium/utils/pricing'
import { pageFinished } from '@baserow/modules/core/utils/routing.js'
import { nextTick } from '#imports'
import { nextTick, useNuxtApp } from '#imports'

export default {
name: 'RegisterLicenseModal',
setup() {
const nuxtApp = useNuxtApp()
return { nuxtApp }
},
emits: ['registered'],
components: { RegisterLicenseForm },
mixins: [modal, error],
Expand Down Expand Up @@ -72,13 +76,13 @@ export default {
values.license
)
this.$emit('registered', data)
await this.$nuxt.$router.push({
await this.$router.push({
name: 'admin-license',
params: {
id: data.id,
},
})
await pageFinished()
await pageFinished(this.nuxtApp)
await nextTick()
} catch (error) {
this.handleError(error, 'license', {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,14 @@ export class ConditionalColorValueProviderType extends DecoratorValueProviderTyp
if (
row.id !== -1 &&
row.id !== undefined &&
matchSearchFilters(operator, filters, filterGroups, fields, row)
matchSearchFilters(
this.app.$registry,
operator,
filters,
filterGroups,
fields,
row
)
) {
return color
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export class RowCommentMentionNotificationType extends NotificationType {
}

getRoute(notificationData) {
return tableRouteResetViewIfNeeded({
return tableRouteResetViewIfNeeded(this.app.$router, {
databaseId: notificationData.database_id,
tableId: notificationData.table_id,
rowId: notificationData.row_id,
Expand All @@ -40,7 +40,7 @@ export class RowCommentNotificationType extends NotificationType {
}

getRoute(notificationData) {
return tableRouteResetViewIfNeeded({
return tableRouteResetViewIfNeeded(this.app.$router, {
databaseId: notificationData.database_id,
tableId: notificationData.table_id,
rowId: notificationData.row_id,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -815,6 +815,7 @@ export const actions = {
return view.filters_disabled
? true
: matchSearchFilters(
this.$registry,
view.filter_type,
view.filters,
view.filter_groups,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,7 @@ export const actions = {
return view.filters_disabled
? true
: matchSearchFilters(
this.$registry,
view.filter_type,
view.filters,
view.filter_groups,
Expand Down
2 changes: 1 addition & 1 deletion web-frontend/modules/automation/applicationTypes.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export class AutomationApplicationType extends ApplicationType {
workflowId: workflows[0].id,
},
})
await pageFinished()
await pageFinished(this.app)
await nextTick()
return true
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
import { notifyIf } from '@baserow/modules/core/utils/error'
import { mapGetters } from 'vuex'
import { pageFinished } from '@baserow/modules/core/utils/routing'
import { nextTick } from '#imports'
import { nextTick, useNuxtApp } from '#imports'

export default {
name: 'SidebarItemAutomation',
Expand All @@ -109,6 +109,10 @@ export default {
required: true,
},
},
setup() {
const nuxtApp = useNuxtApp()
return { nuxtApp }
},
data() {
return {
deleteLoading: false,
Expand Down Expand Up @@ -157,21 +161,21 @@ export default {
}
this.setLoading(automation, true)
try {
await this.$nuxt.$router.push({
await this.$router.push({
name: 'automation-workflow',
params: {
automationId: automation.id,
workflowId: workflow.id,
},
})
await pageFinished()
await pageFinished(this.nuxtApp)
await nextTick()
} finally {
this.setLoading(automation, false)
}
},
resolveWorkflowHref(automation, workflow) {
const props = this.$nuxt.$router.resolve({
const props = this.$router.resolve({
name: 'automation-workflow',
params: {
automationId: automation.id,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ const actions = {
// Redirect back to the dashboard because the workflow doesn't exist anymore.
const router = useRouter()
await router.push({ name: 'dashboard' })
await pageFinished()
await pageFinished(this.app)
await nextTick()
commit('UNSELECT')
}
Expand Down
2 changes: 1 addition & 1 deletion web-frontend/modules/builder/applicationTypes.js
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ export class BuilderApplicationType extends ApplicationType {
pageId: pages[0].id,
},
})
await pageFinished()
await pageFinished(this.app)
await nextTick()
return true
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ import { notifyIf } from '@baserow/modules/core/utils/error'
import { mapGetters } from 'vuex'
import { VISIBILITY_LOGGED_IN } from '@baserow/modules/builder/constants'
import { pageFinished } from '@baserow/modules/core/utils/routing'
import { nextTick } from '#imports'
import { nextTick, useNuxtApp } from '#imports'

export default {
name: 'SidebarItemBuilder',
Expand All @@ -100,6 +100,10 @@ export default {
required: true,
},
},
setup() {
const nuxtApp = useNuxtApp()
return { nuxtApp }
},
data() {
return {
deleteLoading: false,
Expand Down Expand Up @@ -151,21 +155,21 @@ export default {
}
this.setLoading(builder, true)
try {
await this.$nuxt.$router.push({
await this.$router.push({
name: 'builder-page',
params: {
builderId: builder.id,
pageId: page.id,
},
})
await pageFinished()
await pageFinished(this.nuxtApp)
await nextTick()
} finally {
this.setLoading(builder, false)
}
},
resolvePageHref(builder, page) {
const props = this.$nuxt.$router.resolve({
const props = this.$router.resolve({
name: 'builder-page',
params: {
builderId: builder.id,
Expand Down
2 changes: 1 addition & 1 deletion web-frontend/modules/builder/store/page.js
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ const actions = {
commit('UNSELECT')
// Redirect back to the dashboard because the page doesn't exist anymore.
await this.$router.push({ name: 'dashboard' })
await pageFinished()
await pageFinished(this.app)
await nextTick()
}

Expand Down
2 changes: 1 addition & 1 deletion web-frontend/modules/core/components/Tabs.vue
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export default {
else return this.internalSelectedIndex === i
},
getHref(i) {
const router = useRouter()
const router = this.$router
if (this.route) {
const tab = this.tabs[i]
return !tab.disabled ? router.resolve(tab.to).path : null
Expand Down
10 changes: 7 additions & 3 deletions web-frontend/modules/core/components/auth/Login.vue
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ import {
} from '@baserow/modules/core/utils/url'
import TOTPLogin from '@baserow/modules/core/components/auth/TOTPLogin'
import { pageFinished } from '@baserow/modules/core/utils/routing'
import { nextTick } from '#imports'
import { nextTick, useNuxtApp } from '#imports'

export default {
components: {
Expand Down Expand Up @@ -127,6 +127,10 @@ export default {
},
},
emits: ['success'],
setup() {
const nuxtApp = useNuxtApp()
return { nuxtApp }
},
data() {
return {
passwordLoginHiddenIfDisabled: true,
Expand Down Expand Up @@ -180,7 +184,7 @@ export default {
} else {
await this.$router.push({ name: 'dashboard' })
}
await pageFinished()
await pageFinished(this.nuxtApp)
await nextTick()
}
this.$emit('success')
Expand All @@ -195,7 +199,7 @@ export default {
name: 'workspace',
params: { workspaceId: workspace.id },
})
await pageFinished()
await pageFinished(this.nuxtApp)
await nextTick()
}
this.$emit('success')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export default {
return moment.utc(value).format('MMM Do YYYY [at] H:mm')
},
formatSize(size) {
return formatFileSize(size)
return formatFileSize(this.$i18n, size)
},
},
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export default {

methods: {
formatSize(bytes) {
return formatFileSize(bytes)
return formatFileSize(this.$i18n, bytes)
},
async handleRemove() {
if (this.resourceId) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ import SettingsModal from '@baserow/modules/core/components/settings/SettingsMod
import CreateWorkspaceModal from '@baserow/modules/core/components/workspace/CreateWorkspaceModal'
import { escapeRegExp } from '@baserow/modules/core/utils/string'
import { pageFinished } from '@baserow/modules/core/utils/routing'
import { nextTick } from '#imports'
import { nextTick, useNuxtApp } from '#imports'

export default {
name: 'SidebarUserContext',
Expand All @@ -151,6 +151,10 @@ export default {
},
},
emits: ['toggle-admin'],
setup() {
const nuxtApp = useNuxtApp()
return { nuxtApp }
},
data() {
return {
logoffLoading: false,
Expand Down Expand Up @@ -221,7 +225,7 @@ export default {
)
try {
await this.$router.push({ name: activatedAdminTypes[0].routeName })
await pageFinished()
await pageFinished(this.nuxtApp)
await nextTick()
} catch {}
},
Expand All @@ -237,7 +241,7 @@ export default {
name: 'workspace',
params: { workspaceId: workspace.id },
})
await pageFinished()
await pageFinished(this.nuxtApp)
await nextTick()
this.hide()
},
Expand Down
Loading
Loading