Conversation
ref https://linear.app/ghost/issue/BER-3600/design-iteration - Refreshed the gift card with a vertical layout and improved background gradients. - Added a mouse-tracked shine effect on the card. - Wired up the real `gift.expires_at` (purchase date + 365 days) on screens where the gift exists.
ref https://linear.app/ghost/issue/HKG-1761/ The existing helper-only test in this file does not exercise the notification entry points, which is exactly where the URL was historically threaded (line 161 of comments-service-emails.js was missed when the helper was last refactored). Driving notifyPostAuthors and notifyReport end-to-end and pinning that the right post id reaches getUrlByResourceId makes that regression class fail loudly in a single test commit.
no issue - "token" is a very overloaded term in our codebase, this is a small step to making our naming more explicit
ref https://linear.app/ghost/issue/HKG-1767/ The IndexNow listener pings a URL derived from the URL service whenever a post's SEO-relevant fields change. The existing test stubs the URL service as a sanity check but never asserts on the URL that the request body actually carries, so a regression in how the listener resolves the post's URL would slip through. Driving indexnowListener end-to-end and pinning the ping URL through the public boundary closes that gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )