Skip to content

[pull] master from cube-js:master #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Jan 10, 2026
Merged

[pull] master from cube-js:master #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/cubejs-athena-driver/src/AthenaDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ interface AthenaDriverOptions extends AthenaClientConfig {
exportBucket?: string
pollTimeout?: number
pollMaxInterval?: number
athenaAwsAssumeRoleArn?: string
athenaAwsAssumeRoleExternalId?: string

/**
* The export bucket CSV file escape symbol.
Expand Down Expand Up @@ -125,8 +127,13 @@ export class AthenaDriver extends BaseDriver implements DriverInterface {
config.secretAccessKey ||
getEnv('athenaAwsSecret', { dataSource });

const assumeRoleArn = getEnv('athenaAwsAssumeRoleArn', { dataSource });
const assumeRoleExternalId = getEnv('athenaAwsAssumeRoleExternalId', { dataSource });
const assumeRoleArn =
config.athenaAwsAssumeRoleArn ||
getEnv('athenaAwsAssumeRoleArn', { dataSource });

const assumeRoleExternalId =
config.athenaAwsAssumeRoleExternalId ||
getEnv('athenaAwsAssumeRoleExternalId', { dataSource });

const { schema, ...restConfig } = config;

Expand Down
Loading