[pull] master from cube-js:master #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th new Cubestore (#10288) * chore(ci): Temporary commented out some tests due to flaky results with new Cubestore * remove snapshots
…yjs pollution (#10279) * fix(client-core): Isolate internalDayjs instance to prevent global dayjs pollution - Register custom locale 'cube-internal-en' with weekStart: 1 - Restore original global locale after registration - Prevents internalDayjs from affecting global dayjs instance - Add comprehensive test suite for dayjs instance isolation - Fixes issue where calling internalDayjs changed global week start Closes issue where customizing internal dayjs instance affected the default dayjs instance behavior (weekStart changed from 0 to 1) * fix(test): update dayjs isolation tests for accurate week start validation * fix(client-core): restore default dayjs locale after setting custom internal locale * refactor(client-core): Register custom locale without global side effects - Use dayjs.Ls to register locale directly without switching - Eliminates any potential race conditions during module initialization - Ensures zero impact on global dayjs instance throughout lifecycle --------- Co-authored-by: Debjit Mandal <debjitmandal8925@gmail.com> Co-authored-by: Konstantin Burkalev <KSDaemon@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )