[pull] master from cube-js:master #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…10225) (#10226) The fillWithValue pivot config option was using the || (logical OR) operator, which treats 0 as falsy. This caused actual zero values in the data to be incorrectly replaced by fillWithValue, not just missing/undefined values. Changed the implementation to use the ?? (nullish coalescing) operator instead, which only falls through for null and undefined values, preserving actual 0 values in the data. Impact: Users can now use fillWithValue to display 'no data' indicators (like '-' or 'N/A') without also replacing legitimate zeros in their data. Fixes #10225 Co-authored-by: Debjit Mandal <debjitmandal8925@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )