Skip to content

fix: prevent builtin MCPs from overwriting user MCP configs #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-yeongyu merged 1 commit into from
Jan 27, 2026
+1 −1
Merged

fix: prevent builtin MCPs from overwriting user MCP configs #956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugin-handlers/config-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,8 +348,8 @@ export function createConfigHandler(deps: ConfigHandlerDeps) {
: { servers: {} };

config.mcp = {
...(config.mcp as Record<string, unknown>),
...createBuiltinMcps(pluginConfig.disabled_mcps),
...(config.mcp as Record<string, unknown>),
...mcpResult.servers,
...pluginComponents.mcpServers,
};
Comment on lines 350 to 355
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding test coverage for the MCP configuration merging precedence to prevent regression. The fix ensures user configs override builtin MCPs, but there's no automated test verifying this behavior. A test case could verify that when a user defines custom headers for a builtin MCP like 'context7', those headers are preserved in the final merged config.

Copilot uses AI. Check for mistakes.
Expand Down
Loading