fix(ci): build Windows binary natively to avoid cross-compilation segfault #938
+44
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault Bun's cross-compilation from Linux to Windows produces binaries that crash with 'Segmentation fault at address 0xFFFFFFFFFFFFFFFF' (oven-sh/bun#18416). Changes: - Add build-windows-binary job on windows-latest runner - Download Windows binary artifact in publish job before build:binaries - Skip build in build-binaries.ts if binary already exists Fixes code-yeongyu#873
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
3 tasks
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
LilMGenius
force-pushed
the
fix/873-windows-x64-segfault
branch
3 times, most recently
from
7e09f77 to
187e2fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
windows-latestrunner instead of cross-compiling from UbuntuFixes #873
Root Cause
Bun's cross-compilation from Linux to Windows produces binaries that crash with:
This is a known Bun issue: oven-sh/bun#18416
Evidence:
Changes
.github/workflows/publish.yml: Addbuild-windows-binaryjob onwindows-latest, upload artifact, download inpublishjobscript/build-binaries.ts: Skip build if binary already exists (allows pre-built artifact to be used)Testing
bun run typecheckpassesbun run buildsucceeds--versionoutputs correctly