refactor: align builtin skill loader

[vsumner]

Summary

• load builtin skills from SKILL.md-first paths with fallback
• add loader unit tests and playwright SKILL.md
• slim skills.ts to a loader-based export

---

Summary by cubic

Replaces hardcoded built‑in skills with a SKILL.md‑first loader, making skills file-driven and easier to maintain. Adds tests and a Playwright SKILL.md to validate and demonstrate the new format.

• New Features

  • Load skills from SKILL.md in a skill folder, with fallback to .md.
  • Parse frontmatter (description, metadata, mcpConfig) with safe defaults; preserve markdown body as template.
  • Added unit tests for loader behavior and a Playwright SKILL.md example.

• Refactors

  • Replaced the 1,200‑line skills.ts with a loader-based export (createBuiltinSkills).
  • createBuiltinSkills now reads “playwright”, “frontend-ui-ux”, and “git-master” from disk and filters missing entries.

^{Written for commit 1c9b9ff. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 4 files

Confidence score: 3/5

• createBuiltinSkills in src/features/builtin-skills/skills.ts now relies on SKILL.md files that aren’t present, which can yield an empty builtin skills list at runtime and affect functionality
• This is a concrete user-facing behavior change, so the merge carries some regression risk despite only one issue
• Pay close attention to src/features/builtin-skills/skills.ts - dependency on missing filesystem SKILL.md files may empty builtin skills.

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/features/builtin-skills/skills.ts">

<violation number="1" location="src/features/builtin-skills/skills.ts:1">
P1: createBuiltinSkills now depends on filesystem SKILL.md files that are absent, returning an empty builtin skills list at runtime instead of the previous hardcoded skills.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P1: createBuiltinSkills now depends on filesystem SKILL.md files that are absent, returning an empty builtin skills list at runtime instead of the previous hardcoded skills.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/features/builtin-skills/skills.ts, line 1:

<comment>createBuiltinSkills now depends on filesystem SKILL.md files that are absent, returning an empty builtin skills list at runtime instead of the previous hardcoded skills.</comment>

<file context>
@@ -1,1203 +1 @@
-export function createBuiltinSkills(): BuiltinSkill[] {
-  return [playwrightSkill, frontendUiUxSkill, gitMasterSkill]
-}
+export { createBuiltinSkills } from "./loader"
</file context>