refactor: standardize agent factories

[vsumner]

Summary

• introduce shared agent factory helpers for consistent config
• update built-in agents to use the new factory pattern
• document model override behavior in AGENTS.md

---

Summary by cubic

Standardized agent creation with shared factories and refactored built-in agents to use them, ensuring consistent model-specific config and tool restrictions. Updated AGENTS.md to document the factory pattern and model override behavior.

• Refactors

  • Added agent factory utilities: createAgentFactory, createGptAgentFactory, createClaudeAgentFactory, createUnrestrictedAgentFactory, plus isClaudeModel.
  • Migrated Oracle, Librarian, Explore, Frontend UI/UX Engineer, Document Writer, Metis, Momus, Multimodal Looker to factories; auto-applies reasoningEffort (GPT) or thinking (Claude) and centralizes tool restrictions.
  • Expanded AGENTS.md with factory usage, options, model detection, and tool restriction guidance.

• Migration

  • Use factory functions for new/updated agents; pass restrictedTools or allowedTools via options.
  • Rely on factory defaults for GPT vs Claude (reasoningEffort "medium"; thinking enabled with 32k tokens); avoid setting these manually.
  • No breaking changes; existing agent exports and names stay the same.

^{Written for commit 583ae8b. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 11 files

Confidence score: 3/5

• Potential mismatch in model settings: src/agents/utils/factory.ts picks config based on resolvedModel even when extra.model overrides the final config.model, which could apply the wrong model-specific config at runtime.
• Risk is moderate because this is a concrete behavior change with user-facing impact when extra.model is used, but limited in scope to model selection logic.
• Pay close attention to src/agents/utils/factory.ts - model-specific config selection may not align with extra.model overrides.

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/agents/utils/factory.ts">

<violation number="1" location="src/agents/utils/factory.ts:76">
P2: Model-specific config is chosen using `resolvedModel` even though `extra` can override the final `config.model`, producing mismatched model settings when `extra.model` differs.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}