fix(lsp): handle warmupClient initialization errors #888
+14
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix unhandled promise rejection in
warmupClient()that causes process crash when LSP server fails to start.Problem
warmupClient()uses a fire-and-forget pattern but had no error handling:When the LSP server binary is not found, has permission issues, or fails to initialize, the promise rejection goes unhandled, causing:
UnhandledPromiseRejectionerrorReproduction
Solution
Add
.catch()handler to:Changes
src/tools/lsp/client.ts: Add error handling towarmupClient()initialization promiseSummary by cubic
Handle LSP warmup initialization errors to prevent unhandled promise rejections and process crashes. warmupClient() now catches start/initialize failures, logs the error with server ID, removes the failed client, and stops it so the process keeps running.
Written for commit 161da10. Summary will update on new commits.