-
Notifications
You must be signed in to change notification settings - Fork 46
Fix ULW component CLI direct subcommand dispatch #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tully-8888
wants to merge
1
commit into
code-yeongyu:main
from
tully-8888:lazycodex/bug-fix-ulw-cli-direct-dispatch
+53
−1
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
plugins/omo/components/ulw-loop/test/cli-entrypoint.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import { execFile } from "node:child_process"; | ||
| import { mkdtemp, rm } from "node:fs/promises"; | ||
| import { tmpdir } from "node:os"; | ||
| import { join, resolve } from "node:path"; | ||
| import { promisify } from "node:util"; | ||
| import { afterAll, beforeAll, describe, expect, it } from "vitest"; | ||
|
|
||
| const execFileAsync = promisify(execFile); | ||
| const repoRoot = resolve(import.meta.dirname, ".."); | ||
| let qaRoot = ""; | ||
|
|
||
| beforeAll(async () => { | ||
| await execFileAsync("npm", ["run", "build"], { cwd: repoRoot }); | ||
| qaRoot = await mkdtemp(join(tmpdir(), "omo-ulw-loop-cli-entrypoint-")); | ||
| }); | ||
|
|
||
| afterAll(async () => { | ||
| if (qaRoot) await rm(qaRoot, { recursive: true, force: true }); | ||
| }); | ||
|
|
||
| describe("dist/cli.js component entrypoint", () => { | ||
| it("dispatches direct subcommands when invoked as omo-ulw-loop", async () => { | ||
| const cliPath = join(repoRoot, "dist", "cli.js"); | ||
| const result = await execFileAsync(process.execPath, [cliPath, "status", "--json"], { cwd: qaRoot }).catch( | ||
| (error: unknown) => { | ||
| if (error instanceof Error && "stderr" in error && "stdout" in error) { | ||
| return error as Error & { readonly stdout: string; readonly stderr: string }; | ||
| } | ||
| throw error; | ||
| }, | ||
| ); | ||
|
|
||
| expect(result.stderr).toContain("[ulw-loop] No ulw-loop plan found"); | ||
| expect(result.stderr).not.toContain("[omo] unknown command: status"); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Node 20.0–20.10, which is still allowed by this package's
engines: >=20.0.0and the component AGENTS.md guidance,import.meta.dirnameis not available, so this module throws during evaluation before the test can run. The existing tests usefileURLToPath(import.meta.url)/dirname(...); use that pattern here or raise the supported Node floor to a version that providesimport.meta.dirname.Useful? React with 👍 / 👎.