test: disable parallel install of packages in e2e test#984
Merged
Conversation
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 0e3cb8d with previous commit 5f0a8c4. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 1 group regressed, 👍 2 audits improved, 👎 4 audits regressed, 11 audits changed without impacting score🗃️ Groups
20 other groups are unchanged. 🛡️ Audits586 other audits are unchanged. |
matejchalk
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix the error present locally & in CI, that has been caused by parallel
nxv-pkg-installrewriting thepackage.jsonwhen installing dependencies in the per e2etmpfolder.The error was recognizable in the logs as:
Cannot find package '@code-pushup/plugin-****' imported from ... code-pushup.config.bundled_****This was happening randomly, only if the "plugin" was not installed last as it did not rewrite any of the important deps (cli, core,...), but if if was installed sooner, the specific package (cli, core, ...) would emit
package.jsonwithout the plugin or any other important dependency.Detailed examples of failing PRs
Example from recent PR
Example from another PR