refactor: extract wizard infrastructure into utils#1283
Conversation
|
View your CI Pipeline Execution ↗ for commit 860b695
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
13f5d31 to
ebf198d
Compare
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit ee59214 with previous commit 47eb97a. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👎 3 groups regressed, 👍 4 audits improved, 👎 7 audits regressed, 22 audits changed without impacting score🗃️ Groups
29 other groups are unchanged. 🛡️ Audits
645 other audits are unchanged. |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit ee59214 with previous commit 47eb97a. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🔴 23 | 🔴 22 | |
| Code coverage | 🟢 90 | 🟡 90 |
4 other categories are unchanged.
👎 2 groups regressed, 👎 4 audits regressed, 1 audit changed without impacting score
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🔴 23 | 🔴 22 | |
| Code coverage | Code coverage metrics | 🟢 90 | 🟡 90 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Types coverage | 🟥 9 undocumented types | 🟥 9 undocumented types | |
| Code coverage | Function coverage | 🟩 90.4 % | 🟨 89.6 % | |
| Code coverage | Branch coverage | 🟨 89.8 % | 🟨 89.2 % | |
| Code coverage | Line coverage | 🟩 92.2 % | 🟩 92.1 % | |
| JSDocs coverage | Variables coverage | 🟥 17 undocumented variables | 🟥 16 undocumented variables |
438 other audits are unchanged.
💼 Project utils
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🟡 61 | 🟡 61 | |
| Code coverage | 🟢 94 | 🟢 94 |
4 other categories are unchanged.
👍 2 groups improved, 👍 4 audits improved, 👎 2 audits regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🟡 61 | 🟡 61 | |
| Code coverage | Code coverage metrics | 🟢 94 | 🟢 94 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Types coverage | 🟥 58 undocumented types | 🟨 58 undocumented types | |
| JSDocs coverage | Variables coverage | 🟥 52 undocumented variables | 🟥 53 undocumented variables | |
| JSDocs coverage | Functions coverage | 🟥 255 undocumented functions | 🟥 257 undocumented functions | |
| Code coverage | Function coverage | 🟩 94.9 % | 🟩 94.9 % | |
| Code coverage | Branch coverage | 🟩 91.4 % | 🟩 91.5 % | |
| Code coverage | Line coverage | 🟩 97.4 % | 🟩 97.4 % |
438 other audits are unchanged.
💼 Project models
😟 Code PushUp report has regressed.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 94 | 🟢 94 | |
| Documentation | 🟡 67 | 🟡 67 |
2 other categories are unchanged.
👎 2 groups regressed, 👎 2 audits regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 94 | 🟢 94 | |
| JSDocs coverage | Documentation coverage | 🟡 67 | 🟡 67 |
10 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 94 % | 🟩 93.7 % | |
| JSDocs coverage | Types coverage | 🟥 68 undocumented types | 🟥 69 undocumented types |
435 other audits are unchanged.
💼 Project plugin-axe
😟 Code PushUp report has regressed.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 95 | 🟢 95 |
5 other categories are unchanged.
👎 1 group regressed, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 95 | 🟢 95 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟨 76.8 % | 🟨 76.7 % |
442 other audits are unchanged.
💼 Project plugin-coverage
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 94 | 🟢 94 | |
| Documentation | 🟡 68 | 🟡 68 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 94 | 🟢 94 | |
| JSDocs coverage | Documentation coverage | 🟡 68 | 🟡 68 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 91.3 % | 🟩 91.3 % |
443 other audits are unchanged.
9 other projects are unchanged.
create-cliwill soon integratecreate-eslint-config's wizard. Without a shared tree, each would buffer writes separately and we'd maintain two implementations. Sharing one gives us a single buffer and one canonical implementation.The shared module uses
create-eslint-config's implementation rather thancreate-cli's, because it already handles flush rollback, skips writes when content matches disk, and avoids re-recording identical writes, whichcreate-cliwas missing.Additionally, this PR consolidates plugin binding inputs into a single object and extracts the yargs setup, fixing a latent bug where plugin-namespaced CLI flags silently no-opped instead of overriding their prompt defaults.