fix: ensure CLI bin directory is included in published package with executable permissions#1183
Merged
BioPhoton merged 2 commits intocode-pushup:mainfrom Dec 10, 2025
Conversation
|
View your CI Pipeline Execution ↗ for commit a586dcd
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/js-packages-plugin
@code-pushup/eslint-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
dad6225 to
330ff7c
Compare
330ff7c to
17a0669
Compare
BioPhoton
approved these changes
Dec 10, 2025
Collaborator
BioPhoton
left a comment
There was a problem hiding this comment.
Thx for the update! Looks good to me!
Maybe a comment in code to explain the why?
Contributor
Code PushUp😟 Code PushUp report has regressed – compared current commit a86654b with previous commit a86654b. 🏷️ Categories👎 1 group regressed, 👎 5 audits regressed, 12 audits changed without impacting score🗃️ Groups
33 other groups are unchanged. 🛡️ Audits661 other audits are unchanged. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bindirectory is properly included in the npm packagebin/index.jsindex.jsto./bin/index.jsin package.jsonThis fix addresses an issue where the CLI binary wasn't being included in the published npm package because the
filesfield in package.json only included thesrcdirectory. Without this fix, users installing the package via npm wouldn't get the executable bin file.Impact
code-pushupcommand will now work correctly after npm installTechnical Details
The fix involves:
bindirectory to the build assets inproject.jsonto ensure it's copied during buildpackage.jsonfromindex.jsto./bin/index.jsto match the actual file locationbin/index.jsfile is tracked in git with executable permissions (+x) to ensure they're preserved through version control and build processesThis follows a similar pattern to a previous fix (commit 0fd2eb4) that addressed executable permissions for the old location.