feat: implement scoreTargets for audits#1076
Merged
hanna-skryl merged 8 commits intomainfrom Aug 22, 2025
Merged
Conversation
@code-pushup/ci
@code-pushup/create-cli
@code-pushup/models
@code-pushup/cli
@code-pushup/nx-plugin
@code-pushup/core
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit ccf38d8 with previous commit a419aec. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👎 1 group regressed, 👍 6 audits improved, 👎 2 audits regressed, 17 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
585 other audits are unchanged. |
BioPhoton
reviewed
Aug 21, 2025
BioPhoton
reviewed
Aug 21, 2025
BioPhoton
requested changes
Aug 21, 2025
Collaborator
BioPhoton
left a comment
There was a problem hiding this comment.
Left a small naming change
matejchalk
previously approved these changes
Aug 22, 2025
|
View your CI Pipeline Execution ↗ for commit 5d86e2b
☁️ Nx Cloud last updated this comment at |
matejchalk
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #721 (CLI preparation)
This PR implements the CLI preparation phase for the
scoreTargetsfeature for audits.scoreTargetsproperty (single number or per-audit mapping)scoreAuditsWithTargetutility function in theutilspackagescoreTargetstransformation inexecutePluginafter the plugin executionThe following items from the ticket are intentionally deferred:
auditSchemawithtargetScore" - After careful consideration, it's been concluded thatscoreTargetbelongs at the plugin configuration level rather than individual audit definitions. This approach provides greater flexibility, allowing for either a single value applicable to all audits or a per-audit mapping.applyMaxScoreAboveThreshold" - This function remains in the coverage plugin unchanged. Migration to the new generic system is planned for PR4 to maintain backward compatibility.auditToGQLare not needed until PR3, after the portal model adoption (PR2) is complete.