Finish show animation before close#31
Open
jdepypere wants to merge 1 commit intocode-mc:masterfrom
jdepypere:master
Open
Finish show animation before close#31jdepypere wants to merge 1 commit intocode-mc:masterfrom jdepypere:master
jdepypere wants to merge 1 commit intocode-mc:masterfrom
jdepypere:master
Conversation
If `.error()` or `.close()` was called before the `.show()`-animation was done (300ms), the opacity would not have a value of 1 and the error or success message might not be entirely clear. Now the show animation finishes before showing the close animation. Current delay is 300 ms, so allowing the animation to finish seems like a good solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
.error()or.close()was called before the.show()-animation was done (300ms), the opacity would not have a value of 1 and the error or success message might not be entirely clear. Now the show animation finishes before showing the close animation. Current delay is 300 ms, so allowing the animation to finish seems like a good solution.