drpcmanager: use atomic counter for client stream ID generation#46
Open
shubhamdhama wants to merge 1 commit intoshubham/use-stream-finishedfrom
Open
drpcmanager: use atomic counter for client stream ID generation#46shubhamdhama wants to merge 1 commit intoshubham/use-stream-finishedfrom
shubhamdhama wants to merge 1 commit intoshubham/use-stream-finishedfrom
Conversation
shubhamdhama
force-pushed
the
shubham/use-stream-finished
branch
from
779b184 to
341397a
Compare
shubhamdhama
force-pushed
the
shubham/use-atomic-counter
branch
from
f5869a5 to
f204e04
Compare
Decouple client stream ID assignment from sbuf, which tracks the latest stream object. This is a step toward removing sbuf in favor of the stream registry.
shubhamdhama
force-pushed
the
shubham/use-stream-finished
branch
from
341397a to
dcda07e
Compare
shubhamdhama
force-pushed
the
shubham/use-atomic-counter
branch
from
f204e04 to
6abe605
Compare
cthumuluru-crdb
approved these changes
Mar 31, 2026
cthumuluru-crdb
left a comment
cthumuluru-crdb
left a comment
There was a problem hiding this comment.
I wish it was not called the lastStreamID since it is capturing the stream ID that's latest. Lets add some comments on the variable for now to suggest it's the latest stream ID that's consumed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouple client stream ID assignment from sbuf, which tracks the latest
stream object. This is a step toward removing sbuf in favor of the stream
registry.