Skip to content

Update critical nodes endpoint curl examples#23368

Merged
rmloveland merged 5 commits into
mainfrom
20260518-DOC-17121-update-critical-nodes-endpoint-with-curl
May 22, 2026
Merged

Update critical nodes endpoint curl examples#23368
rmloveland merged 5 commits into
mainfrom
20260518-DOC-17121-update-critical-nodes-endpoint-with-curl

Conversation

@rmloveland
Copy link
Copy Markdown
Contributor

Fixes DOC-17121

Summary of changes:

  • Add a top-of-section request pattern for POST /_status/critical_nodes.
  • Show insecure HTTP and secure authenticated HTTPS curl examples.
  • Apply the clarification across all supported docs versions.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 18, 2026

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 55a658d
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/6a10760625290e0007c5c4b2

@netlify
Copy link
Copy Markdown

netlify Bot commented May 18, 2026

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 55a658d
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/6a107606734fb90008686c73

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

Cross-Version Link Check Passed

All cross-version link issues have been resolved. Good job!

@rmloveland rmloveland requested a review from stevendanna May 18, 2026 16:07
@rmloveland
Copy link
Copy Markdown
Contributor Author

rmloveland commented May 18, 2026

@stevendanna not really a very technical update but would appreciate your user POV re: is this easier to scan/find by a busy engineer during an escalation

PS they're all the same update so it's fine to just review e.g. the v26.2 one (or whichever)

@netlify
Copy link
Copy Markdown

netlify Bot commented May 18, 2026

Netlify Preview

Name Link
🔨 Latest commit 55a658d
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/6a1076066f54740008014bdb
😎 Deploy Preview https://deploy-preview-23368--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread src/current/v23.2/monitoring-and-alerting.md
Move curl authentication examples from the critical nodes endpoint
section into a new "Authenticate to API endpoints" section that
applies to all HTTP endpoints on the page. The critical nodes
section now references the shared section via anchor link.

Addresses review feedback from stevendanna on #23368.
@rmloveland rmloveland force-pushed the 20260518-DOC-17121-update-critical-nodes-endpoint-with-curl branch from 7de77e3 to 2eb4633 Compare May 20, 2026 18:20
@rmloveland rmloveland requested a review from a team May 20, 2026 18:20
@taroface taroface self-requested a review May 20, 2026 20:44
Copy link
Copy Markdown
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one syntax/style comment for the whole PR.

Comment thread src/current/v23.2/monitoring-and-alerting.md Outdated
@rmloveland rmloveland enabled auto-merge (squash) May 22, 2026 15:28
@rmloveland rmloveland merged commit 0fafc02 into main May 22, 2026
7 checks passed
@rmloveland rmloveland deleted the 20260518-DOC-17121-update-critical-nodes-endpoint-with-curl branch May 22, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants