Update zone configuration constraints to provide cloud vendor region …#23146
Update zone configuration constraints to provide cloud vendor region …#23146jeevanshu wants to merge 1 commit intocockroachdb:mainfrom
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
jeevanshu
force-pushed
the
zonal-region-config
branch
from
1d39f46 to
9a9e519
Compare
✅ Netlify PreviewBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Netlify PreviewBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
jeevanshu
force-pushed
the
zonal-region-config
branch
2 times, most recently
from
f5caf1b to
0fa2eec
Compare
jeevanshu
force-pushed
the
zonal-region-config
branch
from
0fa2eec to
eb06f2a
Compare
| {% include {{ page.version.version }}/zone-configs/create-a-replication-zone-for-a-table-partition.md %} | ||
|
|
||
| {{site.data.alerts.callout_info}} | ||
| When specifying region constraints or lease preferences for nodes running on cloud providers, you must include the cloud provider prefix in the region name. The format is `{provider}-{region}`. |
There was a problem hiding this comment.
Hi @jeevanshu can you say more about the motivation for this docs PR? it wasn't clear from reading the postmortem in Confluence why this is necessary
this says "you must include the cloud provider prefix in the region name" but AIUI that isn't actually true, the --locality flag just does arbitrary string matching:
https://www.cockroachlabs.com/docs/v26.1/cockroach-start#locality
so it's only necessary to pass that exact string using the cloud provider if that's what you passed to the cockroach binary in the cockroach start --locality flag
this seems like it might be something internal to how we run CockroachCloud and not something that is generally true for self-hosted clusters where people run cockroach start --locality={foo} with arbitrary values of {foo}
but maybe i'm misunderstanding this, please say more about what is motivating this change
There was a problem hiding this comment.
Thanks for the comment @rmloveland.
I was not aware of locality flags can be arbitrary value.
You are also correct about CC clusters, where we pass locality flags to include cloud provider prefix like --locality=region=gcp-asia-southeast1,zone=gcp-asia-southeast1-c.
Context behind this change is during the incident, engineers tried to run the query to restrict zonal config for liveness ranges of CC host cluster away from certain zones but due to regional config missing the cloud provider prefix it was failing and there was no check present to validate the config.
Since it looks to be limited to just CockroachCloud clusters, do you recommend closing this PR and documenting this behaviour elsewhere?
2 participants
Part of CC-34931