-
Notifications
You must be signed in to change notification settings - Fork 477
Update schema changes docs with schema_locked info #21726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
a2eb098 to
2968c4e
Compare
|
@rmloveland TODO: backport these changes (minus the mention of the v26.1 defaults) to supported versions v24.1 and later (pending technical reviewer confirmation) |
rafiss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! the extra linkage is helpful, but we still need to find an accurate way and helpful way to describe the setting. unfortunately, the name schema_locked is quite misleading
rafiss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new phrasing lgtm!
bsanchez-the-roach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-blocking nit, otherwise LGTM
Fixes DOC-15240 NB. These changes are applied to v25.4 and v26.1
66bf7d7 to
dd116b4
Compare
|
thanks for the reviews! backported to v25.4 (modulo default description) and merging ... |
Fixes DOC-15240