Skip to content

sql: add retry to pg_sleep in cursor logictest#161903

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
DrewKimball:cursor-timeout
Jan 28, 2026
Merged

sql: add retry to pg_sleep in cursor logictest#161903
craig[bot] merged 1 commit intocockroachdb:masterfrom
DrewKimball:cursor-timeout

Conversation

@DrewKimball
Copy link
Copy Markdown
Collaborator

This commit attempts to prevent flakes in the cursor logictest by adding a retry.

Fixes #161599

Release note: None

This commit attempts to prevent flakes in the cursor logictest by
adding a retry.

Fixes cockroachdb#161599

Release note: None
@DrewKimball DrewKimball requested review from a team and mw5h and removed request for a team January 27, 2026 23:00
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@yuzefovich yuzefovich added backport-25.2.x Flags PRs that need to be backported to 25.2 backport-25.4.x Flags PRs that need to be backported to 25.4 backport-26.1.x Flags PRs that need to be backported to 26.1 labels Jan 28, 2026
Copy link
Copy Markdown
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yuzefovich reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @mw5h).

@DrewKimball
Copy link
Copy Markdown
Collaborator Author

TFTR!

bors r=yuzefovich

@craig
Copy link
Copy Markdown
Contributor

craig Bot commented Jan 28, 2026

@craig craig Bot merged commit e01438c into cockroachdb:master Jan 28, 2026
26 checks passed
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented Jan 28, 2026

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #161599: branch-release-25.2, branch-release-25.4.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@DrewKimball DrewKimball deleted the cursor-timeout branch January 28, 2026 17:36
trunk-io Bot added a commit that referenced this pull request Jan 28, 2026
Backport 1/1 commits from #161903 on behalf of @DrewKimball.

----

This commit attempts to prevent flakes in the cursor logictest by adding a retry.

Fixes #161599

Release note: None

----

Release justification: test-only change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-25.2.x Flags PRs that need to be backported to 25.2 backport-25.4.x Flags PRs that need to be backported to 25.4 backport-26.1.x Flags PRs that need to be backported to 26.1 v26.2.0-prerelease

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pkg/sql/logictest/tests/fakedist-vec-off/fakedist-vec-off_test: TestLogic_cursor failed

3 participants