Skip to content

release-24.3: sql/schemachanger: deflake TestPause.*#161893

Merged
fqazi merged 1 commit intocockroachdb:release-24.3from
fqazi:blathers/backport-release-24.3-161884
Jan 28, 2026
Merged

release-24.3: sql/schemachanger: deflake TestPause.*#161893
fqazi merged 1 commit intocockroachdb:release-24.3from
fqazi:blathers/backport-release-24.3-161884

Conversation

@fqazi
Copy link
Copy Markdown
Collaborator

@fqazi fqazi commented Jan 27, 2026

Backport 1/1 commits from #161884 on behalf of @fqazi.


Previously, these tests could timeout, because they had a short time interval to wait for schema changes to complete (the default of 45 seconds). This patch makes the pause tests wait for completion before checking the final status.

Fixes: #161743
Fixes: #161742
Fixes: #161693
Fixes: #161456

Release note: None


Release justification: test only change

Previously, these tests could timeout, because they had a short time
interval to wait for schema changes to complete (the default of 45
seconds). This patch makes the pause tests wait for completion before
checking the final status.

Fixes: cockroachdb#161743
Fixes: cockroachdb#161742
Fixes: cockroachdb#161693
Fixes: cockroachdb#161456

Release note: None
@fqazi fqazi force-pushed the blathers/backport-release-24.3-161884 branch from 098e141 to 0832746 Compare January 27, 2026 21:42
@fqazi fqazi requested a review from a team as a code owner January 27, 2026 21:42
@blathers-crl blathers-crl Bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 27, 2026
@blathers-crl blathers-crl Bot requested a review from rafiss January 27, 2026 21:42
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented Jan 27, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl Bot added backport Label PR's that are backports to older release branches T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Jan 27, 2026
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented Jan 27, 2026

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented Jan 27, 2026

✅ PR #161893 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The pull request is compliant with the backport policy for the following reasons: 1. It contains a 'Release justification: test only change' in the PR body, which explicitly indicates that this is a test-only modification. According to the CockroachDB backport policy, changes that are solely for non-production, test-only files are exempt from standard backport policy requirements including the need for the change fixing a critical bug or being gated behind a feature flag. 2. The modified file 'pkg/sql/schemachanger/sctest/cumulative.go' fits the pattern of test files (e.g., files in test scenarios or infrastructure). Consequently, the changes are deemed non-production, supporting the test-only exemption.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rafiss rafiss added the backport-test-only Used to denote the backport has only non-production changes label Jan 27, 2026
@fqazi fqazi merged commit fb6f95c into cockroachdb:release-24.3 Jan 28, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) v24.3.29

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants