changefeedccl: create kafka topics via api call#161870
Open
asg0451 wants to merge 1 commit intocockroachdb:masterfrom
Open
changefeedccl: create kafka topics via api call#161870asg0451 wants to merge 1 commit intocockroachdb:masterfrom
asg0451 wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Add support for creating kafka topics via api call, instead of relying on the kafka cluster having auto topic creation enabled. This can be enabled with the changefeed option `create_kafka_topics='yes'`. The option can also be set to `'no'` to disable topic creation, or `'auto'` to automatically create topics if they don't exist (default) (previous behaviour). Fixes: cockroachdb#155157 Release note (general change): The changefeed option `create_kafka_topics` now supports the values `'yes'`, `'no'`, and `'auto'` (default).
asg0451
requested review from
jeffswenson,
shailendra-patel and
williamchoe3
and removed request for
a team
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for creating kafka topics via api
call, instead of relying on the kafka cluster
having auto topic creation enabled. This can be
enabled with the changefeed option
create_kafka_topics='yes'. The option can alsobe set to
'no'to disable topic creation, or'auto'to automatically create topics if theydon't exist (default) (previous behaviour).
Fixes: #155157
Release note (general change): The changefeed option
create_kafka_topicsnow supports the values'yes','no', and'auto'(default).