Skip to content

Conversation

@kev-cao
Copy link
Contributor

@kev-cao kev-cao commented Dec 12, 2025

Backport 1/1 commits from #159006.

/cc @cockroachdb/release


This test is flaky and superfluous as our mixed version roachtests already test backup with offline nodes.

Fixes: #158654

Release note: None


Release justification: Test-only change.

@kev-cao kev-cao requested a review from a team as a code owner December 12, 2025 20:09
@kev-cao kev-cao requested review from dt and removed request for a team December 12, 2025 20:09
@blathers-crl
Copy link

blathers-crl bot commented Dec 12, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-disaster-recovery labels Dec 12, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Dec 12, 2025

✅ PR #159421 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The pull request is compliant as it strictly pertains to test-only changes. The modified file backup_tenant_test.go falls under the category of test files (*_test.go), which are exempt from the main backport policy requirements according to the non-production assessment criteria. Since the changes involve the removal of a test case described as 'flaky and superfluous', this qualifies the PR as adhering to the provided exceptions for non-production file changes in backporting.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@kev-cao kev-cao changed the title backup: remove TestBackupSharedProcessTenantNodeDown release 24.3: backup: remove TestBackupSharedProcessTenantNodeDown Dec 12, 2025
This test is flaky and superfluous as our mixed version roachtests
already test backup with offline nodes.

Fixes: cockroachdb#158654

Release note: None
@kev-cao kev-cao force-pushed the backport24.3-159006 branch from a3a379c to c96cb45 Compare December 12, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches T-disaster-recovery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants