Skip to content

Conversation

@tbg
Copy link
Member

@tbg tbg commented Dec 12, 2025

Backport 2/2 commits from #159279 on behalf of @tbg.


In an escalation1, we observed that on larger clusters,
multiple rounds of runtime.Stacks are required until the buffer
sizing algorithm as produced a large enough buffer.
Since grabbing stacks will cause stop-the-world pauses,
this is best avoided.

NB: *serverpb.StacksRequest is already populated using allstacks.Get.

Fixes #159285.

Release note (bug fix): the performance impact of the automatic goroutine dumper has been reduced by reducing the number of stop-the-world events it causes (especially on large, busy systems).

Epic: none


Release justification:

Footnotes

  1. https://github.com/cockroachlabs/support/issues/3495#issuecomment-3622936905

tbg added 2 commits December 11, 2025 15:45
In an escalation[^1], we observed that on larger clusters,
multiple rounds of runtime.Stacks are required until the buffer
sizing algorithm as produced a large enough buffer.
Since grabbing stacks will cause stop-the-world pauses,
this is best avoided.

Fixes cockroachdb#159285.

[^1]: cockroachlabs/support#3495 (comment)

Epic: none
@tbg tbg requested review from a team as code owners December 12, 2025 17:16
@tbg tbg requested review from kyle-a-wong and removed request for a team December 12, 2025 17:16
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 12, 2025
@blathers-crl
Copy link

blathers-crl bot commented Dec 12, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot requested review from arulajmani and dt December 12, 2025 17:16
@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-kv KV Team labels Dec 12, 2025
@blathers-crl
Copy link

blathers-crl bot commented Dec 12, 2025

❌ PR #159392 does not comply with backport policy

Confidence: high
Explanation: The PR does not clearly fulfill any specific critical bug criteria under the backport policy. While it addresses performance improvements by reducing stop-the-world events, the description lacks evidence that this qualifies as a 'significant performance regression' or 'stability issue'. Furthermore, no feature flags are mentioned or introduced in this PR, making it non-compliant according to the backport policy. The PR does not mention removing any version gates, suggesting that it may be backward compatible. However, the 'Release justification' section in the PR body is incomplete, providing no explicit reasoning to support policy exception.
Recommendation: Reconsider the backport or provide a clearer justification and demonstration that the performance impact aligns with the critical bug criteria, or alternatively, gate the changes behind a feature flag.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-kv KV Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants