release-25.2: allstacks: improve buffer alloc sizing and adopt more widely #159392
+72
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #159279 on behalf of @tbg.
In an escalation1, we observed that on larger clusters,
multiple rounds of runtime.Stacks are required until the buffer
sizing algorithm as produced a large enough buffer.
Since grabbing stacks will cause stop-the-world pauses,
this is best avoided.
NB:
*serverpb.StacksRequestis already populated usingallstacks.Get.Fixes #159285.
Release note (bug fix): the performance impact of the automatic goroutine dumper has been reduced by reducing the number of stop-the-world events it causes (especially on large, busy systems).
Epic: none
Release justification:
Footnotes
https://github.com/cockroachlabs/support/issues/3495#issuecomment-3622936905 ↩