Skip to content

chore(api): Rework the way we handle errors on url precheck #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vvatelot merged 1 commit into from
Mar 18, 2025
Merged

chore(api): Rework the way we handle errors on url precheck #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bases/ecoindex/backend/routers/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,11 @@ async def add_ecoindex_analysis_task(
try:
r = requests.head(url=web_page.url, timeout=5)
r.raise_for_status()
except Exception:
except requests.exceptions.RequestException as e:
raise HTTPException(
status_code=521,
status_code=e.response.status_code
if e.response
else status.HTTP_400_BAD_REQUEST,
detail=f"The URL {web_page.url} is unreachable. Are you really sure of this url? 🤔",
)

Expand Down