feat(mysql): make rsa dependency optional (RUSTSEC-2023-0071)#1
Merged
Conversation
Signed-off-by: Sylvain Pierrot <spierrot@aalyria.com>
Signed-off-by: Sylvain Pierrot <spierrot@aalyria.com>
…uth warnings Signed-off-by: Sylvain Pierrot <spierrot@aalyria.com>
…ssword in CI and tests Signed-off-by: Sylvain Pierrot <spierrot@aalyria.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rsacrate an opt-in feature ofsqlx-mysqlto address RUSTSEC-2023-0071 (Marvin Attack timing side-channel, no patched release)sha256_password/caching_sha2_passwordover non-TLS) behindfeatures = ["rsa"]; returns a clear error when the feature is absentmysql_native_passwordto avoid requiring RSACopied entirely from launchbadge#4186
Test plan
cargo buildsucceeds withoutrsafeature (TLS-only usage)cargo build --features rsasucceeds and non-TLS RSA auth workscargo auditno longer flags RUSTSEC-2023-0071 whenrsafeature is disabled🤖 Generated with Claude Code