generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 217
feat: Add custom size props to modal #4252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amanabiy
wants to merge
8
commits into
dev-v3-amanabiy-modal-top-position
Choose a base branch
from
dev-v3-amanabiy-modal
base: dev-v3-amanabiy-modal-top-position
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+522
−232
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2fdbf25
feat: add custom width and height props
amanabiy 18652f6
test: add snapshot update for tests
amanabiy 75629fd
chore: made no footer configurable
amanabiy d916652
fix: improve the api documentation for more readability
amanabiy 8fb1d19
fix: use space-s instead of space-static-s
amanabiy a67d4d1
chore: use xs for breakpoint
amanabiy 2072409
chore: update snapshot and inforce footer on test
amanabiy a2c44ac
fix: handle NaN dimensions gracefully
amanabiy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| import React, { useState } from 'react'; | ||
|
|
||
| import { Button, Checkbox, FormField, Input, Modal, SpaceBetween } from '~components'; | ||
|
|
||
| import { useAppContext } from '../app/app-context'; | ||
| import { SimplePage } from '../app/templates'; | ||
| import ScreenshotArea from '../utils/screenshot-area'; | ||
|
|
||
| export default function () { | ||
| const { urlParams, setUrlParams } = useAppContext(); | ||
| const [visible, setVisible] = useState(false); | ||
| const showFooter = urlParams.footer ? true : false; | ||
| const footer = <Button variant="primary">OK</Button>; | ||
|
|
||
| return ( | ||
| <SimplePage | ||
| title="Modal with custom dimensions" | ||
| settings={ | ||
| <SpaceBetween size="m"> | ||
| <FormField label="Width (px)"> | ||
| <Input | ||
| value={urlParams.width ? String(urlParams.width) : ''} | ||
| onChange={e => setUrlParams({ width: e.detail.value })} | ||
| type="number" | ||
| /> | ||
| </FormField> | ||
| <FormField label="Height (px)"> | ||
| <Input | ||
| value={urlParams.height ? String(urlParams.height) : ''} | ||
| onChange={e => setUrlParams({ height: e.detail.value })} | ||
| type="number" | ||
| /> | ||
| </FormField> | ||
| <Checkbox checked={showFooter} onChange={e => setUrlParams({ footer: e.detail.checked })}> | ||
| Show footer | ||
| </Checkbox> | ||
| </SpaceBetween> | ||
| } | ||
| > | ||
| <Button data-testid="modal-trigger" onClick={() => setVisible(true)}> | ||
| Show modal | ||
| </Button> | ||
| <ScreenshotArea> | ||
| <Modal | ||
| header="Custom dimensions modal" | ||
| visible={visible} | ||
| onDismiss={() => setVisible(false)} | ||
| width={Number(urlParams.width) || undefined} | ||
| height={Number(urlParams.height) || undefined} | ||
| footer={showFooter ? footer : undefined} | ||
| > | ||
| {Array(100) | ||
| .fill(0) | ||
| .map((value, index) => ( | ||
| <div key={index}> | ||
| <span>Text content {index}</span> | ||
| </div> | ||
| ))} | ||
| <input data-testid="final-input" /> | ||
| </Modal> | ||
| </ScreenshotArea> | ||
| </SimplePage> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.