Skip to content

feat: add x-large and xx-large sizes to modal#4240

Draft
amanabiy wants to merge 11 commits intomainfrom
dev-v3-amanabiy-modal-new-sizes
Draft

feat: add x-large and xx-large sizes to modal#4240
amanabiy wants to merge 11 commits intomainfrom
dev-v3-amanabiy-modal-new-sizes

Conversation

@amanabiy
Copy link
Member

@amanabiy amanabiy commented Feb 11, 2026

Description

This PR adds two new size options to Modal component: x-large (1024px) and xx-large (1280px).

Related links, issue #, if available: gfq0AFhyrah9

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.35%. Comparing base (f81e1dc) to head (874c6ae).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4240      +/-   ##
==========================================
+ Coverage   97.30%   97.35%   +0.05%     
==========================================
  Files         888      889       +1     
  Lines       26012    26059      +47     
  Branches     9408     9418      +10     
==========================================
+ Hits        25312    25371      +59     
+ Misses        694      682      -12     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments