fix race conditions on stage/unstage volume #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alakae
reviewed
Dec 17, 2025
mweibel
force-pushed
the
release/3.5.7-prerelease
branch
6 times, most recently
from
4f1856c to
39b17bf
Compare
udevadm when called concurrently may potentially redo symlinks. Adding a lock, so if multiple pods attach at the same time, we don't call udevadm concurrently. Adjusts the order so we first check if the device is available, before doing udevadm calls. Adjust order of udevadm calls itself: first trigger, then settle. Reason: - settle waits for new events to finish - trigger triggers new events but doesn't wait for them Improve logging and increase the amount of logs (in debug level) to potentially debug issues with more data.
- add volume locks to avoid concurrent operations on the same volume - add detection if symlinks don't add up to the right volume - increase logging once more - test: add concurrency/race condition tests - fix ptr/nonptr receiver - add lint target and fix lint errors
mweibel
force-pushed
the
release/3.5.7-prerelease
branch
from
9952c20 to
cbcd901
Compare
Collaborator
Author
|
workflow |
alakae
reviewed
Jan 13, 2026
Comment on lines
+98
to
+99
| GOBIN=$(shell go env GOPATH)/bin | ||
| GOLANGCI_LINT_VER=v2.8.0 |
Contributor
There was a problem hiding this comment.
Suggestion: Consider installing from a tool.mod file, similar to the approach used in CCM:
I generally prefer to avoid curl | bash. Let me know your thoughts on this approach!
| | 1.28 | v3.3.0 | v3.5.6 | | ||
| | 1.29 | v3.3.0 | v3.5.6 | | ||
| | 1.30 | v3.3.0 | v3.5.6 | | ||
| | 1.24 | v3.1.0 | v3.5.7-rc2 | |
Contributor
There was a problem hiding this comment.
we must be extra careful that all these entries are correct, when releasing:
- update lines for the latests kubernetes versions
- min version 1.28 according to CHANGELOG.md
- be sure that the final version does not mention any rc versions.
Comment on lines
+3
to
+12
| ## v3.5.7-rc2 - 2025.12.23 | ||
| * Minimum supported Kubernetes version is now 1.28. | ||
| * add volume locks to avoid concurrent operations on the same volume | ||
| * add detection if symlinks don't add up to the right volume | ||
| * increase logging once more | ||
|
|
||
| ## v3.5.7-rc1 - 2025.12.17 | ||
| * Adjust udevadm calls & reorder them, and put them behind a mutex to avoid a potential race condition | ||
| * Improve logging by adding debug logs | ||
| * Add `--log-level=(trace|debug|info|warn|error)` flag to customize log level |
Contributor
There was a problem hiding this comment.
question: what do you think; is it better to mention both rcs in the final version, or should we create a new single entry for v3.5.7?
| }).Info("successfully found attached volume_id at device_path") | ||
|
|
||
| // Debug logging to help diagnose potential race conditions with concurrent volume mounts | ||
| resolvedSource, resolveErr := filepath.EvalSymlinks(source) |
Contributor
There was a problem hiding this comment.
suggestion: can we wrap EvalSymlinks into a log level check?
e.g.: if d.log.Logger.IsLevelEnabled(logrus.DebugLevel).
| } | ||
|
|
||
| // Resolve source symlink for debug logging | ||
| resolvedSource, resolveErr := filepath.EvalSymlinks(source) |
Contributor
There was a problem hiding this comment.
same comment as in the other file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of race conditions with node stage/unstage etc. calls.
adjust udevadm calls
udevadm when called concurrently may potentially redo symlinks.
Adding a lock, so if multiple pods attach at the same time, we don't
call udevadm concurrently.
Adjusts the order so we first check if the device is available, before
doing udevadm calls.
Adjust order of udevadm calls itself: first trigger, then settle.
Reason:
improve node stage volume mounting
lint issues