fix(node): reject staging path mounted from unexpected source#152
Merged
Conversation
disperate
approved these changes
Jun 3, 2026
mweibel
force-pushed
the
node-request-logger
branch
from
01d8e88 to
9d1fbe5
Compare
Verify if stagingTargetPath is mounted and verify the mount source matches what we expect. This verification is done using LUKS paths or by resolving the symlink in the other case. To simplify the API surface, the code has been refactored to have a new GetMountInfo function which answers both former IsMounted and GetMountSources APIs.
mweibel
force-pushed
the
stage-source-verify
branch
from
3c0c3a8 to
c2adec9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify if stagingTargetPath is mounted and verify the mount source matches what we expect.
This verification is done using LUKS paths or by resolving the symlink in the other case.
To simplify the API surface, the code has been refactored to have a new GetMountInfo function which answers both former IsMounted and GetMountSources APIs.