fix(node): give every gRPC handler a request-scoped logger#151
Merged
Conversation
The node-service RPCs previously logged with the package-level default logger and ad-hoc field names, so the same volume_id appeared under different keys (sometimes "volume_id", sometimes "device_path") and many lines landed without enough context to correlate with kubelet's view. Build a single *logrus.Entry at the top of each handler with the canonical request fields (volume_id, staging_target_path, target_path, …) and thread it through the helpers. Additionally, fixes two instances of using error equality check instead of errors.Is.
mweibel
force-pushed
the
node-request-logger
branch
from
01d8e88 to
9d1fbe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The node-service RPCs previously logged with the package-level default logger and ad-hoc field names, so the same volume_id appeared under different keys (sometimes "volume_id", sometimes "device_path") and many lines landed without enough context to correlate with kubelet's view.
Build a single *logrus.Entry at the top of each handler with the canonical request fields (volume_id, staging_target_path, target_path, …) and thread it through the helpers.
Additionally, fixes two instances of using error equality check instead of errors.Is.