Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/inline-loader.asset.php
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array(), 'version' => '2814799d655f563dcef8');
<?php return array('dependencies' => array(), 'version' => 'ddf62970fa28de856098');
2 changes: 1 addition & 1 deletion js/inline-loader.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion js/lazy-load.asset.php
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array(), 'version' => 'ded1dd3da3fe93cb64da');
<?php return array('dependencies' => array(), 'version' => '763fff6b35eade3cc6d2');
2 changes: 1 addition & 1 deletion js/lazy-load.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions src/js/inline-loader.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { roundToHalf } from './utils';

const CloudinaryLoader = {
deviceDensity: window.devicePixelRatio ? window.devicePixelRatio : 'auto',
density: null,
Expand Down Expand Up @@ -151,11 +153,20 @@ const CloudinaryLoader = {
return 1;
}
let deviceDensity = this.deviceDensity;

// Round to nearest 0.5 to reduce URL variations
if ( 'auto' !== deviceDensity ) {
deviceDensity = roundToHalf( deviceDensity );
}

if (
'max' !== maxDensity &&
'auto' !== deviceDensity
) {
maxDensity = parseFloat( maxDensity );

// Round maxDensity to nearest 0.5 to maintain consistency
maxDensity = roundToHalf( maxDensity );
deviceDensity =
deviceDensity > Math.ceil( maxDensity )
? maxDensity
Expand Down
10 changes: 10 additions & 0 deletions src/js/lazy-load.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { roundToHalf } from './utils';

const LazyLoad = {
deviceDensity: window.devicePixelRatio ? window.devicePixelRatio : 'auto',
density: null,
Expand Down Expand Up @@ -73,11 +75,19 @@ const LazyLoad = {
return 1;
}
let deviceDensity = this.deviceDensity;

// Round to nearest 0.5 to reduce URL variations
if ( 'auto' !== deviceDensity ) {
deviceDensity = roundToHalf( deviceDensity );
}

if (
'max' !== maxDensity &&
'auto' !== deviceDensity
) {
maxDensity = parseFloat( maxDensity );
// Round maxDensity to nearest 0.5 to maintain consistency
maxDensity = roundToHalf( maxDensity );
deviceDensity =
deviceDensity > Math.ceil( maxDensity )
? maxDensity
Expand Down
10 changes: 10 additions & 0 deletions src/js/utils.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
/**
* Rounds a number to the nearest 0.5 increment.
* This reduces URL variations for DPR values.
*
* @param {number} value - The value to round.
* @return {number} The rounded value (e.g., 1.666 -> 1.5, 2.3 -> 2.5).
*/
export const roundToHalf = ( value ) => {
return Math.round( value * 2 ) / 2;
};