Skip to content

fix: remove aria-live from volumeBar#1002

Merged
tsi merged 1 commit intomasterfrom
fix/volume-bar-remove-aria-live
Mar 16, 2026
Merged

fix: remove aria-live from volumeBar#1002
tsi merged 1 commit intomasterfrom
fix/volume-bar-remove-aria-live

Conversation

@tsi
Copy link
Collaborator

@tsi tsi commented Mar 15, 2026

Adds a temporary DOM patch so the volume bar’s aria-live attribute is removed after the player is ready. This avoids NVDA announcing the volume value repeatedly.

This patch can be removed once Video.js includes the upstream fix.

@tsi tsi self-assigned this Mar 15, 2026
@tsi tsi requested a review from a team as a code owner March 15, 2026 09:09
@netlify
Copy link

netlify bot commented Mar 15, 2026

Deploy Preview for cld-video-player ready!

Name Link
🔨 Latest commit 3aecb32
🔍 Latest deploy log https://app.netlify.com/projects/cld-video-player/deploys/69b677551bb17100085063ad
😎 Deploy Preview https://deploy-preview-1002--cld-video-player.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 15, 2026

Deploy Preview for cld-vp-esm-pages ready!

Name Link
🔨 Latest commit 3aecb32
🔍 Latest deploy log https://app.netlify.com/projects/cld-vp-esm-pages/deploys/69b67755b1bac300086946d1
😎 Deploy Preview https://deploy-preview-1002--cld-vp-esm-pages.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tsi tsi merged commit 008220c into master Mar 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants