Skip to content

Fix webview compliance issues#11

Merged
njb90 merged 1 commit intomainfrom
fix/webview-compliance
Mar 27, 2026
Merged

Fix webview compliance issues#11
njb90 merged 1 commit intomainfrom
fix/webview-compliance

Conversation

@njb90
Copy link
Copy Markdown
Collaborator

@njb90 njb90 commented Mar 27, 2026

  • Removed unsafe createWebviewDocument (no CSP, no nonce) and its escapeHtml import — all callers already use webviewUtils.ts
  • escapeHtml(cloudName) → JSON.stringify(cloudName) — escapeHtml HTML-encodes & to & inside JS strings, JSON.stringify is the correct escaping for JS contexts
  • Replaced innerHTML template with DOM APIs — fileName is now set via .title and .textContent
  • Replaced card.innerHTML template with DOM APIs — asset.public_id, asset.secure_url, and
    folderDisplay are now set via setAttribute/textContent

@njb90 njb90 merged commit a23c4d9 into main Mar 27, 2026
1 check passed
@njb90 njb90 deleted the fix/webview-compliance branch March 27, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant