Skip to content

Adapt immutables style to match cf-java-client-sap project #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theghost5800 merged 1 commit into from
Aug 5, 2025
Merged

Adapt immutables style to match cf-java-client-sap project #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...apps-common/src/main/java/org/cloudfoundry/multiapps/common/MultiappsImmutablesStyle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@

/**
* Used for generation of code via <a href="https://immutables.github.io/">Immutables</a>.
*
*/
@Value.Style(depluralize = true, jdkOnly = true, allowedClasspathAnnotations = java.lang.Override.class)
@Value.Style(depluralize = true, jdkOnly = true, allowedClasspathAnnotations = java.lang.Override.class, visibility = Value.Style.ImplementationVisibility.PUBLIC, typeImmutableNested = "Immutable*")
Copy link
Contributor

@ikasarov ikasarov Aug 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the one thing that's missing from the previous style config is

typeImmutable = "Immutable*"

in addition to typeImmutableNested. Do we not need it?

Copy link
Contributor Author

@theghost5800 theghost5800 Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default value is matching previously set configuration.

public @interface MultiappsImmutablesStyle {

}