Add GCP Objectstore SDK instead of JClouds #1723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMCROSSITXSADEPLOY-3313
Yavor16
force-pushed
the
adopt-gcp-os-sdk
branch
from
7b20da8 to
ac576b8
Compare
multiapps-controller-persistence/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...rg/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorageTest.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...ce/src/main/java/org/cloudfoundry/multiapps/controller/persistence/util/ObjectStoreUtil.java
Outdated
Show resolved
Hide resolved
...rg/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorageTest.java
Outdated
Show resolved
Hide resolved
...y/multiapps/controller/web/configuration/bean/factory/ObjectStoreFileStorageFactoryBean.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...oudfoundry/multiapps/controller/web/configuration/service/ObjectStoreServiceInfoCreator.java
Outdated
Show resolved
Hide resolved
Yavor16
force-pushed
the
adopt-gcp-os-sdk
branch
from
097220f to
704d12b
Compare
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...ce/src/main/java/org/cloudfoundry/multiapps/controller/persistence/util/ObjectStoreUtil.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
IvanBorislavovDimitrov
previously approved these changes
Oct 29, 2025
...oundry/multiapps/controller/web/configuration/service/ObjectStoreServiceInfoCreatorTest.java
Outdated
Show resolved
Hide resolved
...oundry/multiapps/controller/web/configuration/service/ObjectStoreServiceInfoCreatorTest.java
Outdated
Show resolved
Hide resolved
...va/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
Show resolved
Hide resolved
...ce/src/main/java/org/cloudfoundry/multiapps/controller/persistence/util/ObjectStoreUtil.java
Outdated
Show resolved
Hide resolved
...a/org/cloudfoundry/multiapps/controller/persistence/services/ObjectStoreFileStorageTest.java
Outdated
Show resolved
Hide resolved
...a/org/cloudfoundry/multiapps/controller/persistence/services/ObjectStoreFileStorageTest.java
Outdated
Show resolved
Hide resolved
...y/multiapps/controller/web/configuration/bean/factory/ObjectStoreFileStorageFactoryBean.java
Outdated
Show resolved
Hide resolved
.../org/cloudfoundry/multiapps/controller/web/configuration/service/ObjectStoreServiceInfo.java
Outdated
Show resolved
Hide resolved
...rg/cloudfoundry/multiapps/controller/persistence/services/JCloudsObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
...rg/cloudfoundry/multiapps/controller/persistence/services/JCloudsObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
Contributor
|
check Coverage on New Code |
s-yonkov-yonkov
previously approved these changes
Nov 4, 2025
multiapps-controller-persistence/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
Comment on lines
43
to
45
| private static final Duration OBJECTSTORE_TOTAL_TIMEOUT_CONFIG = Duration.ofMinutes(10); | ||
| private static final Duration OBJECTSTORE_MAX_RETRY_DELAY_CONFIG = Duration.ofSeconds(10); | ||
| private static final Duration OBJECTSTORE_INITIAL_RETRY_DELAY_CONFIG = Duration.ofMillis(250); |
Contributor
There was a problem hiding this comment.
Add the name of the unit at the end of the name, IN_SECONDS, IN_MINUTES
|
IvanBorislavovDimitrov
approved these changes
Nov 4, 2025
s-yonkov-yonkov
approved these changes
Nov 4, 2025
Yavor16
added a commit
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.