Add an occasional message when a task execution fails to complete for a long time LMCROSSITXSADEPLOY-3279 #1704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...controller-process/src/main/java/org/cloudfoundry/multiapps/controller/process/Messages.java
Outdated
Show resolved
Hide resolved
...java/org/cloudfoundry/multiapps/controller/process/steps/PollExecuteTaskStatusExecution.java
Outdated
Show resolved
Hide resolved
...java/org/cloudfoundry/multiapps/controller/process/steps/PollExecuteTaskStatusExecution.java
Outdated
Show resolved
Hide resolved
| if (lastLog == null) { | ||
| lastLog = Constants.LONG_DEFAULT_NULL_VALUE; | ||
| } | ||
| if (!lastLog.equals(Constants.LONG_DEFAULT_NULL_VALUE)) { |
Contributor
There was a problem hiding this comment.
This if statement can be removed if default value is set
Contributor
There was a problem hiding this comment.
But if statement is still present, is it really removed?
...process/src/main/java/org/cloudfoundry/multiapps/controller/process/variables/Variables.java
Outdated
Show resolved
Hide resolved
.../java/org/cloudfoundry/multiapps/controller/process/steps/PollExecuteTaskStatusStepTest.java
Outdated
Show resolved
Hide resolved
karrgov
force-pushed
the
timed_message_for_stalled_execution
branch
2 times, most recently
from
59cf55a to
4419e7f
Compare
… a long time LMCROSSITXSADEPLOY-3279
karrgov
force-pushed
the
timed_message_for_stalled_execution
branch
from
4419e7f to
6883328
Compare
...java/org/cloudfoundry/multiapps/controller/process/steps/PollExecuteTaskStatusExecution.java
Outdated
Show resolved
Hide resolved
LMCROSSITXSADEPLOY-3279
s-yonkov-yonkov
changed the title
s-yonkov-yonkov
changed the title
s-yonkov-yonkov
previously approved these changes
Sep 24, 2025
...java/org/cloudfoundry/multiapps/controller/process/steps/PollExecuteTaskStatusExecution.java
Outdated
Show resolved
Hide resolved
LMCROSSITXSADEPLOY-3279
s-yonkov-yonkov
previously approved these changes
Sep 25, 2025
...ontroller-process/src/main/java/org/cloudfoundry/multiapps/controller/process/Constants.java
Outdated
Show resolved
Hide resolved
| if (lastLog == null) { | ||
| lastLog = Constants.LONG_DEFAULT_NULL_VALUE; | ||
| } | ||
| if (!lastLog.equals(Constants.LONG_DEFAULT_NULL_VALUE)) { |
Contributor
There was a problem hiding this comment.
But if statement is still present, is it really removed?
LMCROSSITXSADEPLOY-3279
LMCROSSITXSADEPLOY-3279
theghost5800
approved these changes
Sep 29, 2025
Contributor
|
Squash commits before merge |
s-yonkov-yonkov
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an occasional message when a task execution fails to complete for a long time
LMCROSSITXSADEPLOY-3279