fix wrong validation message for deep module properties #1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMCROSSITXSADEPLOY-268
Yavor16
reviewed
Aug 5, 2025
Comment on lines
39
to
40
| new Expectation(Expectation.Type.EXCEPTION, | ||
| "Unable to resolve \"hello-backend#backend#routes/0/route")), |
Contributor
There was a problem hiding this comment.
Why do you expect now an exception if you've only changed the message?
Yavor16
requested changes
Aug 11, 2025
Contributor
Yavor16
left a comment
Yavor16
left a comment
There was a problem hiding this comment.
I think nothing is changed here. Can you close this PR if there aren't changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LMCROSSITXSADEPLOY-268