File based bindings #1669

theghost5800 · 2025-07-14T13:33:27Z

No description provided.

s-yonkov-yonkov · 2025-07-24T09:15:32Z

pom.xml

        <jackson.databind.version>2.19.1</jackson.databind.version>
        <liquibase.version>4.32.0</liquibase.version>
        <liquibase-slf4j.version>5.1.0</liquibase-slf4j.version>
-        <cloudfoundry-client.version>2.58.0</cloudfoundry-client.version>


Revert this

This change in adopted cloudfoundrry client is done temporary to test the change. Before merge It will be necessary to adopt new release of cf-java-client or just move whole project into multiapps-controller 😆

s-yonkov-yonkov · 2025-07-24T11:36:27Z

...src/main/java/org/cloudfoundry/multiapps/controller/core/parser/StagingParametersParser.java

+        Map<String, Boolean> appFeatures = (Map<String, Boolean>) PropertiesUtil.getPropertyValue(parametersList,
+                                                                                                  SupportedParameters.APP_FEATURES,
+                                                                                                  Collections.emptyMap());
+        Map<String, Boolean> appFeaturesWithOverriddenSsh = new HashMap<>(appFeatures);
+        if (isSshEnabled != null && !appFeatures.containsKey(Constants.APP_FEATURE_SSH)) {
+            appFeaturesWithOverriddenSsh.put(Constants.APP_FEATURE_SSH, isSshEnabled);
+        }


Please extract this logic in separate method like:

Map<String, Boolean> appFeatures = getNormalizedAppFeatures(parametersList, isSshEnabled);

Also do we need to use two Map objects?

Yes, this is necessary in case when app-features parameter is not set and still ssh-enabled is used. This is done in order to be backwards compatible.

s-yonkov-yonkov · 2025-07-24T12:25:50Z

...re/src/test/java/org/cloudfoundry/multiapps/controller/core/cf/v2/CloudModelBuilderTest.java

+				// (48) app-features parameter with multiple features enabled/disabled
+				Arguments.of(
+						"/mta/app-features/mtad-app-features.yaml", "/mta/app-features/config-app-features.mtaext", "/mta/cf-platform.json", null, null, false,
+						new String[] { "feature-app" }, // mtaArchiveModules


extract constants

...g/cloudfoundry/multiapps/controller/core/validators/parameters/AppFeaturesValidatorTest.java

s-yonkov-yonkov · 2025-07-24T13:34:33Z

...ler-process/src/main/resources/org/cloudfoundry/multiapps/controller/process/deploy-app.bpmn

      </extensionElements>
    </callActivity>
    <sequenceFlow id="sid-26C87D1E-88D5-47E3-907B-0F8EBBCD2C36" sourceRef="executeTasksCallActivity" targetRef="publishProvidedDependenciesTask"></sequenceFlow>
-    <callActivity id="hooksCallActivity" name="Execute Hooks Call Activity" flowable:async="true" calledElement="${hookProcessGetter.get(hookForExecution, execution)}" flowable:calledElementType="key" flowable:inheritVariables="false" flowable:completeAsync="true" flowable:fallbackToDefaultTenant="false">


why this is removed inheritVariables="false"

This is really interesting topic how was set at first place because flowable modeler did remove this explicit set to false.

...ler-process/src/main/resources/org/cloudfoundry/multiapps/controller/process/deploy-app.bpmn

s-yonkov-yonkov

Check comments

IvanBorislavovDimitrov · 2025-07-28T13:19:20Z

...src/main/java/org/cloudfoundry/multiapps/controller/core/parser/StagingParametersParser.java

    }

+    @SuppressWarnings("unchecked")
+    private Map<String, Boolean> getAppFeatures(List<Map<String, Object>> parametersList, Boolean isSshEnabled) {


this method does too many things, split it and reduce number of params

IvanBorislavovDimitrov · 2025-07-28T13:19:59Z

...src/main/java/org/cloudfoundry/multiapps/controller/core/parser/StagingParametersParser.java

        String healthCheckHttpEndpoint = (String) PropertiesUtil.getPropertyValue(parametersList,
                                                                                  SupportedParameters.HEALTH_CHECK_HTTP_ENDPOINT,
                                                                                  getDefaultHealthCheckHttpEndpoint(healthCheckType));
        Boolean isSshEnabled = (Boolean) PropertiesUtil.getPropertyValue(parametersList, SupportedParameters.ENABLE_SSH, null);


will we depracate this?

We don't have such discussion yet but most probably yes because app-feature parameter will unite all similar settings including ssh enablement. With this change if ssh-enabled and app-features: ssh: true/false were specified, it will print warning and will ignore ssh-enabled parameter value.

IvanBorislavovDimitrov · 2025-07-28T13:44:17Z

...a/org/cloudfoundry/multiapps/controller/process/util/StagingApplicationAttributeUpdater.java

        return !StringUtils.isBlank(newCommand) && !Objects.equals(newCommand, existingProcess.getCommand());
    }

+    private boolean isAppFeaturesChanged(Map<String, Boolean> newAppFeatures, Map<String, Boolean> existingAppFeatures) {


rename to areAppFeaturesChanged ?

IvanBorislavovDimitrov · 2025-07-28T13:48:40Z

...a/org/cloudfoundry/multiapps/controller/process/util/StagingApplicationAttributeUpdater.java

+        return newAppFeatures.entrySet()
+                             .stream()
+                             .anyMatch(newAppFeature -> !Objects.equals(newAppFeature.getValue(),


what will happen if someone deletes their app features from the descriptor?
this will result in false, and we will not modify the already existing app features -> in context of cf deploy
in blue-green we will creata a new app and it will have the CF defaults?
Is this an inconsisteny and should we provide default values for app features?

I think it's not good idea to set default values on our own, it is already done by cloudfoundry itself. In the case where application already exist is interesting what to do because we cannot just get default values from cf, the only app feature which is configured per space is ssh enablement - https://v3-apidocs.cloudfoundry.org/version/3.196.0/#list-space-features
if we set explicitly now default values for app features, in future when new app features are added we won't have default values for them. The whole feature parameter is implemented in a way that allows customers easily to specify all app feature parameters in the future.

JIRA:LMCROSSITXSADEPLOY-3111

sonarqubecloud · 2025-08-05T11:22:31Z

Quality Gate failed

Failed conditions
71.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

theghost5800 force-pushed the fileBasedBindings branch from c7bd974 to 4ea6213 Compare July 14, 2025 14:22