Skip to content

Conversation

@stiv03
Copy link
Contributor

@stiv03 stiv03 commented Jul 9, 2025

No description provided.

import com.fasterxml.jackson.core.type.TypeReference;

@Named
public class ConfigurationEntryService extends PersistenceService<ConfigurationEntry, ConfigurationEntryDto, Long> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exclude this class for the PR because here you don't change anything

import static java.text.MessageFormat.format;

@Named
public class ConfigurationSubscriptionService extends PersistenceService<ConfigurationSubscription, ConfigurationSubscriptionDto, Long> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this class also

@stiv03 stiv03 force-pushed the add-audit-logs branch 2 times, most recently from a05a6e6 to a08e30e Compare July 14, 2025 12:36
Yavor16
Yavor16 previously approved these changes Jul 15, 2025
ikasarov
ikasarov previously approved these changes Jul 18, 2025
Comment on lines 81 to 83
requires static org.immutables.value;
requires spring.security.oauth2.client;
requires jakarta.annotation;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure you need that

Yavor16
Yavor16 previously approved these changes Jul 25, 2025
ikasarov
ikasarov previously approved these changes Aug 7, 2025
Yavor16
Yavor16 previously approved these changes Aug 7, 2025
Copy link
Contributor

@Yavor16 Yavor16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to squash

@stiv03 stiv03 dismissed stale reviews from Yavor16 and ikasarov via e7ab23f August 7, 2025 10:14
ikasarov
ikasarov previously approved these changes Aug 11, 2025
@ikasarov ikasarov merged commit b0a99c3 into cloudfoundry:master Aug 11, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants