Adopt apache http client 5 #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanBorislavovDimitrov
force-pushed
the
apache-http-5
branch
from
47814cf to
b23bf47
Compare
...er-core/src/main/java/org/cloudfoundry/multiapps/controller/core/http/HttpClientFactory.java
Outdated
Show resolved
Hide resolved
IvanBorislavovDimitrov
force-pushed
the
apache-http-5
branch
2 times, most recently
from
039fca8 to
56bf914
Compare
theghost5800
previously approved these changes
Jun 16, 2025
...er-core/src/main/java/org/cloudfoundry/multiapps/controller/core/http/HttpClientFactory.java
Outdated
Show resolved
Hide resolved
...er-core/src/main/java/org/cloudfoundry/multiapps/controller/core/http/HttpClientFactory.java
Outdated
Show resolved
Hide resolved
...r-core/src/test/java/org/cloudfoundry/multiapps/controller/core/http/CsrfHttpClientTest.java
Outdated
Show resolved
Hide resolved
Contributor
|
Check coverage on new Code |
IvanBorislavovDimitrov
force-pushed
the
apache-http-5
branch
from
56bf914 to
bfcc051
Compare
Contributor
Author
|
coverage is low because of the factory and the code use for mocks in the tests :D |
| import org.apache.hc.core5.util.TimeValue; | ||
| import org.apache.hc.core5.util.Timeout; | ||
|
|
||
| public class HttpClientFactory { |
Contributor
There was a problem hiding this comment.
Where is this class used? Do we need it in this project?
Contributor
Author
There was a problem hiding this comment.
moved
LMCROSSITXSADEPLOY-1549
IvanBorislavovDimitrov
force-pushed
the
apache-http-5
branch
from
bfcc051 to
29876f6
Compare
|
theghost5800
approved these changes
Jun 17, 2025
s-yonkov-yonkov
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.