Skip to content

Fail on sync calls if specified #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IvanBorislavovDimitrov merged 1 commit into from
May 20, 2025
Merged

Fail on sync calls if specified #1634

IvanBorislavovDimitrov merged 1 commit into from
May 20, 2025

Conversation

@IvanBorislavovDimitrov
Copy link
Contributor

@IvanBorislavovDimitrov IvanBorislavovDimitrov commented May 19, 2025

LMCROSSITXSADEPLOY-3200

@IvanBorislavovDimitrov
Copy link
Contributor Author

IvanBorislavovDimitrov commented May 20, 2025

coverage is lower because of get methods that do not have logic

theghost5800
theghost5800 reviewed May 20, 2025
View reviewed changes
@IvanBorislavovDimitrov
Fail on sync calls if specified
bb0acef 
LMCROSSITXSADEPLOY-3200
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 20, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
57.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@IvanBorislavovDimitrov IvanBorislavovDimitrov merged commit c2df062 into master May 20, 2025
7 of 8 checks passed
@IvanBorislavovDimitrov IvanBorislavovDimitrov deleted the fail-on-service-update branch May 20, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theghost5800 theghost5800 theghost5800 approved these changes

@Yavor16 Yavor16 Yavor16 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IvanBorislavovDimitrov @theghost5800 @Yavor16