Add uploaded file validation #1626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../org/cloudfoundry/multiapps/controller/core/validators/parameters/FileMimeTypeValidator.java
Fixed
Show fixed
Hide fixed
Yavor16
force-pushed
the
add-uploaded-file-validation
branch
from
c37cda8 to
8810415
Compare
.../org/cloudfoundry/multiapps/controller/core/validators/parameters/FileMimeTypeValidator.java
Show resolved
Hide resolved
.../org/cloudfoundry/multiapps/controller/core/validators/parameters/FileMimeTypeValidator.java
Outdated
Show resolved
Hide resolved
.../org/cloudfoundry/multiapps/controller/core/validators/parameters/FileMimeTypeValidator.java
Outdated
Show resolved
Hide resolved
.../org/cloudfoundry/multiapps/controller/core/validators/parameters/FileMimeTypeValidator.java
Fixed
Show fixed
Hide fixed
.../org/cloudfoundry/multiapps/controller/core/validators/parameters/FileMimeTypeValidator.java
Outdated
Show resolved
Hide resolved
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Outdated
Show resolved
Hide resolved
...eb/src/main/java/org/cloudfoundry/multiapps/controller/web/api/impl/FilesApiServiceImpl.java
Outdated
Show resolved
Hide resolved
.../org/cloudfoundry/multiapps/controller/core/validators/parameters/FileMimeTypeValidator.java
Show resolved
Hide resolved
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Outdated
Show resolved
Hide resolved
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/cloudfoundry/multiapps/controller/process/stream/LazyArchiveInputStream.java
Outdated
Show resolved
Hide resolved
...iapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/Messages.java
Outdated
Show resolved
Hide resolved
...iapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/Messages.java
Outdated
Show resolved
Hide resolved
.../cloudfoundry/multiapps/controller/core/validators/parameters/FileMimeTypeValidatorTest.java
Outdated
Show resolved
Hide resolved
IvanBorislavovDimitrov
approved these changes
May 13, 2025
Contributor
IvanBorislavovDimitrov
left a comment
IvanBorislavovDimitrov
left a comment
There was a problem hiding this comment.
Consider running stress tests with a larger archive to check whether tika reads the whole archive to extract the type. Check for performance degradation
LMCROSSITXSADEPLOY-3175
Yavor16
force-pushed
the
add-uploaded-file-validation
branch
from
f5fb5f9 to
b9c0d28
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.