Add warning for unsupported parameters #1607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkalapov
force-pushed
the
unsupported-param-warning
branch
from
4881703 to
87b5c2d
Compare
...rocess/src/main/java/org/cloudfoundry/multiapps/controller/process/util/ReferenceFinder.java
Outdated
Show resolved
Hide resolved
...in/java/org/cloudfoundry/multiapps/controller/process/steps/CollectSystemParametersStep.java
Show resolved
Hide resolved
...ess/src/main/java/org/cloudfoundry/multiapps/controller/process/util/SchemaVersionUtils.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/cloudfoundry/multiapps/controller/process/util/ModuleHooksAggregator.java
Outdated
Show resolved
Hide resolved
...rocess/src/main/java/org/cloudfoundry/multiapps/controller/process/util/ReferenceFinder.java
Outdated
Show resolved
Hide resolved
...rocess/src/main/java/org/cloudfoundry/multiapps/controller/process/util/ReferenceFinder.java
Outdated
Show resolved
Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/process/util/SupportedParametersChecker.java
Outdated
Show resolved
Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/process/util/SupportedParametersChecker.java
Outdated
Show resolved
Hide resolved
Contributor
|
Check the failing checks |
s-yonkov-yonkov
requested changes
Mar 18, 2025
Contributor
s-yonkov-yonkov
left a comment
s-yonkov-yonkov
left a comment
There was a problem hiding this comment.
Please review comments
Contributor
Author
|
Tests fail due to missing version of the multiapps dependency, which is not released yet. |
ikasarov
reviewed
Mar 21, 2025
...main/java/org/cloudfoundry/multiapps/controller/process/util/SupportedParametersChecker.java
Outdated
Show resolved
Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/process/util/SupportedParametersChecker.java
Outdated
Show resolved
Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/process/util/SupportedParametersChecker.java
Outdated
Show resolved
Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/process/util/SupportedParametersChecker.java
Outdated
Show resolved
Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/process/util/SupportedParametersChecker.java
Outdated
Show resolved
Hide resolved
...rocess/src/main/java/org/cloudfoundry/multiapps/controller/process/util/ReferenceFinder.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/cloudfoundry/multiapps/controller/process/steps/MergeDescriptorsStep.java
Outdated
Show resolved
Hide resolved
ikasarov
reviewed
Apr 4, 2025
...main/java/org/cloudfoundry/multiapps/controller/process/util/UnsupportedParameterFinder.java
Outdated
Show resolved
Hide resolved
ikasarov
reviewed
Apr 22, 2025
.../src/main/java/org/cloudfoundry/multiapps/controller/process/steps/MergeDescriptorsStep.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/cloudfoundry/multiapps/controller/process/util/ModuleHooksAggregator.java
Outdated
Show resolved
Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/process/util/UnsupportedParameterFinder.java
Outdated
Show resolved
Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/process/util/UnsupportedParameterFinder.java
Outdated
Show resolved
Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/process/util/UnsupportedParameterFinder.java
Outdated
Show resolved
Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/process/util/UnsupportedParameterFinder.java
Outdated
Show resolved
Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/process/util/UnsupportedParameterFinder.java
Outdated
Show resolved
Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/process/util/UnsupportedParameterFinder.java
Show resolved
Hide resolved
.../test/java/org/cloudfoundry/multiapps/controller/process/steps/MergeDescriptorsStepTest.java
Show resolved
Hide resolved
.../test/java/org/cloudfoundry/multiapps/controller/process/steps/MergeDescriptorsStepTest.java
Outdated
Show resolved
Hide resolved
s-yonkov-yonkov
previously approved these changes
Apr 28, 2025
ikasarov
reviewed
Apr 28, 2025
...main/java/org/cloudfoundry/multiapps/controller/process/util/UnsupportedParameterFinder.java
Outdated
Show resolved
Hide resolved
vkalapov
force-pushed
the
unsupported-param-warning
branch
from
9c89a0e to
2e403c5
Compare
ikasarov
reviewed
Apr 28, 2025
.../src/main/java/org/cloudfoundry/multiapps/controller/process/util/ModuleHooksAggregator.java
Outdated
Show resolved
Hide resolved
.../main/java/org/cloudfoundry/multiapps/controller/process/util/ReferenceContainerMatcher.java
Outdated
Show resolved
Hide resolved
vkalapov
force-pushed
the
unsupported-param-warning
branch
from
2e403c5 to
3fd66ee
Compare
LMCROSSITXSADEPLOY-3137
vkalapov
force-pushed
the
unsupported-param-warning
branch
from
3fd66ee to
2ec1492
Compare
|
s-yonkov-yonkov
approved these changes
Apr 28, 2025
ikasarov
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Issue: