-
Notifications
You must be signed in to change notification settings - Fork 42
Zip entry offsets #1562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Zip entry offsets #1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07e0a08 to
df0b97b
Compare
Yavor16
reviewed
Nov 18, 2024
.../java/org/cloudfoundry/multiapps/controller/persistence/services/ObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
Yavor16
reviewed
Nov 18, 2024
...undry/multiapps/controller/process/steps/DetermineServiceCreateUpdateServiceActionsStep.java
Outdated
Show resolved
Hide resolved
Yavor16
reviewed
Nov 18, 2024
...src/main/java/org/cloudfoundry/multiapps/controller/process/steps/ProcessMtaArchiveStep.java
Outdated
Show resolved
Hide resolved
Yavor16
reviewed
Nov 18, 2024
...src/main/java/org/cloudfoundry/multiapps/controller/process/steps/ProcessMtaArchiveStep.java
Outdated
Show resolved
Hide resolved
Yavor16
reviewed
Nov 18, 2024
...ain/java/org/cloudfoundry/multiapps/controller/process/util/ApplicationDigestCalculator.java
Show resolved
Hide resolved
Yavor16
reviewed
Nov 18, 2024
...ain/java/org/cloudfoundry/multiapps/controller/process/util/ApplicationDigestCalculator.java
Show resolved
Hide resolved
Yavor16
reviewed
Nov 18, 2024
...ain/java/org/cloudfoundry/multiapps/controller/process/util/ApplicationDigestCalculator.java
Show resolved
Hide resolved
Yavor16
reviewed
Nov 18, 2024
.../src/main/java/org/cloudfoundry/multiapps/controller/process/util/ApplicationZipBuilder.java
Outdated
Show resolved
Hide resolved
Yavor16
reviewed
Nov 18, 2024
.../src/main/java/org/cloudfoundry/multiapps/controller/process/util/ArchiveEntryExtractor.java
Outdated
Show resolved
Hide resolved
Yavor16
reviewed
Nov 18, 2024
.../src/main/java/org/cloudfoundry/multiapps/controller/process/util/ArchiveEntryExtractor.java
Outdated
Show resolved
Hide resolved
Yavor16
reviewed
Nov 18, 2024
967c065 to
5575bac
Compare
Yavor16
reviewed
Nov 19, 2024
.../java/org/cloudfoundry/multiapps/controller/process/util/ServiceBindingParametersGetter.java
Outdated
Show resolved
Hide resolved
Yavor16
reviewed
Nov 19, 2024
...ain/java/org/cloudfoundry/multiapps/controller/process/util/ApplicationDigestCalculator.java
Outdated
Show resolved
Hide resolved
Yavor16
reviewed
Nov 19, 2024
...undry/multiapps/controller/process/steps/DetermineServiceCreateUpdateServiceActionsStep.java
Outdated
Show resolved
Hide resolved
...udfoundry/multiapps/controller/persistence/query/providers/ExternalSqlFileQueryProvider.java
Show resolved
Hide resolved
...in/java/org/cloudfoundry/multiapps/controller/persistence/services/FileContentToProcess.java
Show resolved
Hide resolved
...src/main/java/org/cloudfoundry/multiapps/controller/process/steps/ProcessMtaArchiveStep.java
Show resolved
Hide resolved
.../src/main/java/org/cloudfoundry/multiapps/controller/process/util/ApplicationZipBuilder.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/cloudfoundry/multiapps/controller/process/util/ApplicationZipBuilder.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/cloudfoundry/multiapps/controller/process/util/ApplicationZipBuilder.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/cloudfoundry/multiapps/controller/process/util/ArchiveEntryExtractor.java
Show resolved
Hide resolved
...ss/src/main/java/org/cloudfoundry/multiapps/controller/process/util/FileEntryProperties.java
Show resolved
Hide resolved
88ac515 to
9bbbf99
Compare
theghost5800
previously approved these changes
Nov 21, 2024
Yavor16
previously approved these changes
Nov 21, 2024
3c9166b
9bbbf99 to
3c9166b
Compare
|
theghost5800
approved these changes
Nov 22, 2024
Contributor
Author
|
Coverage is lower because of the backwards compatibility logic and SQL providers that only throws exceptions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


The core logic of reading the zip streaming is changed: