Use storage-cli types instead of legacy fog provider names#4908
Draft
Use storage-cli types instead of legacy fog provider names#4908
Conversation
Accept storage-cli native types in config and temporarily map legacy fog provider names for backward compatibility during some time.
kathap
force-pushed
the
blobstore-storage-cli-types
branch
from
c87e1fd to
83b4313
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept storage-cli native types in config and temporarily map legacy fog provider names for backward compatibility during some time.
A short explanation of the proposed change:
This change allows the blobstore storage-cli configuration to use native storage-cli IaaS types (azurebs, alioss, s3, gcs) instead of the historic fog provider names (AzureRM, aliyun, AWS, Google).
For a temporary migration period, the legacy fog provider names are still accepted and internally mapped to the corresponding storage-cli types. This ensures existing configurations continue to work while allowing operators to migrate to the new format.
WebDAV (dav / webdav) remains disabled since the storage-cli backend is not yet fully supported.
The legacy fog mapping is intended to be removed in the future.
An explanation of the use cases your change solves
Currently the storage-cli configuration uses historic fog provider names even though fog is no longer part of the storage path. This creates confusion because the values in the config do not match the provider types expected by storage-cli.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests